Skip to content

[SPARK-16587] [CORE] The annotation for the abstract Class 'BlockTransferMessage' missing several kind of messages. #14232

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
biaoma-ty wants to merge 1 commit into from
+3 −0
Closed

[SPARK-16587] [CORE] The annotation for the abstract Class 'BlockTransferMessage' missing several kind of messages. #14232

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 3 additions & 0 deletions ...shuffle/src/main/java/org/apache/spark/network/shuffle/protocol/BlockTransferMessage.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -35,6 +35,9 @@
* shuffle service. It returns a StreamHandle.
* - UploadBlock is only handled by the NettyBlockTransferService.
* - RegisterExecutor is only handled by the external shuffle service.
* - StreamHandle is only handled by the OneForOneBlockFetcher.
Copy link
Contributor

@vanzin vanzin Aug 4, 2016

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is already covered in the documentation of OpenBlock, since StreamHandle is the reply to OpenBlock.

* - RegisterDriver is only handled by the MesosExternalShuffleService.
* - HearBeat is only handled by the MesosExternalShuffleService.
Copy link
Member

@srowen srowen Jul 16, 2016

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

HeartBeat. (This could also be an HTML list.) I am not sure these docs match the others. They're describing what's handled by the Netty service for external shuffle block handler, not just a class where they're used.

Copy link
Author

@biaoma-ty biaoma-ty Jul 16, 2016 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is it right to modify them like below ?

StreamHandle is only handled by the external shuffle service
RegisterDriver & HeatBeat is only handled by the external shuffle service while the cluster in the mesos deploy mode.

Copy link
Member

@srowen srowen Jul 16, 2016

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Best to ask the author where possible; use Blame to see who wrote these parts. @aarondav ?

*/
public abstract class BlockTransferMessage implements Encodable {
protected abstract Type type();
Expand Down