[SPARK-16303][DOCS][EXAMPLES] Minor Scala/Java example update #14245
+35
−36
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
|
LGTM. Can we reuse a existing jira number? |
|
Test build #62449 has finished for PR 14245 at commit
|
Contributor
|
FWIW I think it'd be better to name the file SparkSQLExamples, rather than SparkSqlExamples. It just feels weird to have SparkSql. And I'm talking about both Scala and Python. |
liancheng
changed the title
liancheng
changed the title
liancheng
changed the title
Contributor
Author
|
Reused JIRA number SPARK-16303 and renamed Scala/Java example file names. Python examples are not being updated to use the |
liancheng
force-pushed
the
minor-scala-example-update
branch
from
03491fd to
927c46a
Compare
|
Test build #62462 has finished for PR 14245 at commit
|
|
Test build #62461 has finished for PR 14245 at commit
|
Contributor
|
Thanks. Merging to master and branch 2.0. |
asfgit
pushed a commit
that referenced
this pull request
Jul 19, 2016
## What changes were proposed in this pull request? This PR moves one and the last hard-coded Scala example snippet from the SQL programming guide into `SparkSqlExample.scala`. It also renames all Scala/Java example files so that all "Sql" in the file names are updated to "SQL". ## How was this patch tested? Manually verified the generated HTML page. Author: Cheng Lian <lian@databricks.com> Closes #14245 from liancheng/minor-scala-example-update. (cherry picked from commit 1426a08) Signed-off-by: Yin Huai <yhuai@databricks.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
This PR moves one and the last hard-coded Scala example snippet from the SQL programming guide into
SparkSqlExample.scala. It also renames all Scala/Java example files so that all "Sql" in the file names are updated to "SQL".How was this patch tested?
Manually verified the generated HTML page.