Skip to content

Conversation

@WeichenXu123
Copy link
Contributor

What changes were proposed in this pull request?

replace ANN convergence tolerance param default
from 1e-4 to 1e-6

so that it will be the same with other algorithms in MLLib which use LBFGS as optimizer.

How was this patch tested?

Existing Test.

@srowen
Copy link
Member

srowen commented Jul 20, 2016

Although it's not necessarily true that two different algos using L-BFGS need about the same convergence tolerance, I do agree in this case that they probably should match up. It's a small change to the defaults, so LGTM

@SparkQA
Copy link

SparkQA commented Jul 20, 2016

Test build #62610 has finished for PR 14286 at commit cd86df5.

  • This patch passes all tests.
  • This patch merges cleanly.
  • This patch adds no public classes.

@srowen
Copy link
Member

srowen commented Jul 25, 2016

Merged to master

@asfgit asfgit closed this in ad3708e Jul 25, 2016
@WeichenXu123 WeichenXu123 deleted the update_ann_tol branch July 31, 2016 09:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants