[SPARK-16703][SQL] Remove extra whitespace in SQL generation for window functions #14334
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Test build #62770 has finished for PR 14334 at commit
|
Contributor
|
Can you add a JIRA ticket? |
Member
|
Hi, @liancheng . SPARK_GENERATE_GOLDEN_FILES=1 build/sbt "hive/test-only *LogicalPlanToSQLSuite" |
liancheng
changed the title
Contributor
Author
|
@rxin @dongjoon-hyun Thanks! JIRA ticket added and updated the golden files. |
Contributor
|
BTW can you change the title to say "Remove extra whitespace in SQL generation for window functions"? |
|
Test build #62797 has finished for PR 14334 at commit
|
Contributor
|
LGTM |
Member
|
After merging this PR, I will rebase my PR #14257 . |
liancheng
changed the title
Contributor
Author
|
@rxin PR title updated. |
Contributor
|
Merging in master/2.0. |
asfgit
pushed a commit
that referenced
this pull request
Jul 25, 2016
…ow functions ## What changes were proposed in this pull request? This PR fixes a minor formatting issue of `WindowSpecDefinition.sql` when no partitioning expressions are present. Before: ```sql ( ORDER BY `a` ASC ROWS BETWEEN UNBOUNDED PRECEDING AND CURRENT ROW) ``` After: ```sql (ORDER BY `a` ASC ROWS BETWEEN UNBOUNDED PRECEDING AND CURRENT ROW) ``` ## How was this patch tested? New test case added in `ExpressionSQLBuilderSuite`. Author: Cheng Lian <lian@databricks.com> Closes #14334 from liancheng/window-spec-sql-format. (cherry picked from commit 7ea6d28) Signed-off-by: Reynold Xin <rxin@databricks.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
This PR fixes a minor formatting issue of
WindowSpecDefinition.sqlwhen no partitioning expressions are present.Before:
After:
How was this patch tested?
New test case added in
ExpressionSQLBuilderSuite.