Skip to content

Conversation

@viirya
Copy link
Member

@viirya viirya commented Jul 25, 2016

What changes were proposed in this pull request?

Fix two places in SQLConf documents regarding size in bytes and statistics.

How was this patch tested?

No. Just change document.

@viirya
Copy link
Member Author

viirya commented Jul 25, 2016

cc @cloud-fan @liancheng Just minor document changes. Please review if this change is proper. Thanks.

@cloud-fan
Copy link
Contributor

LGTM

@SparkQA
Copy link

SparkQA commented Jul 25, 2016

Test build #62790 has finished for PR 14341 at commit 2b555f4.

  • This patch passes all tests.
  • This patch merges cleanly.
  • This patch adds no public classes.

@viirya
Copy link
Member Author

viirya commented Jul 27, 2016

ping @cloud-fan

"by default the optimizer will not choose to broadcast a table unless it knows for sure " +
"its size is small enough.")
.doc("The default table size used in query planning. By default, it is set to Long.MaxValue " +
"which is more than `spark.sql.autoBroadcastJoinThreshold` to be more conservative. " +
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

which is larger than

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

fixed.

@SparkQA
Copy link

SparkQA commented Jul 27, 2016

Test build #62913 has finished for PR 14341 at commit 4df7315.

  • This patch passes all tests.
  • This patch merges cleanly.
  • This patch adds no public classes.

@cloud-fan
Copy link
Contributor

thanks, merging to master

@asfgit asfgit closed this in 045fc36 Jul 27, 2016
@viirya viirya deleted the fix-doc-size-in-bytes branch December 27, 2023 18:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants