Skip to content

Conversation

@philipphoffmann
Copy link
Contributor

What changes were proposed in this pull request?

(Please fill in changes proposed in this fix)

How was this patch tested?

(Please explain how this patch was tested. E.g. unit tests, integration tests, manual tests)

(If this patch involves UI changes, please attach a screenshot; otherwise, remove this)

Mesos agents by default will not pull docker images which are cached
locally already. In order to run Spark executors from mutable tags like
:latest this commit introduces a Spark setting
(spark.mesos.executor.docker.forcePullImage). Setting this flag to
true will tell the Mesos agent to force pull the docker image (default is false which is consistent with the previous
implementation and Mesos' default
behaviour).

Mesos agents by default will not pull docker images which are cached
locally already. In order to run Spark executors from mutable tags like
`:latest` this commit introduces a Spark setting
(`spark.mesos.executor.docker.forcePullImage`). Setting this flag to
true will tell the Mesos agent to force pull the docker image (default is `false` which is consistent with the previous
implementation and Mesos' default
behaviour).
@srowen
Copy link
Member

srowen commented Jul 26, 2016

Jenkins add to whitelist

@srowen
Copy link
Member

srowen commented Jul 26, 2016

Jenkins test this please

@SparkQA
Copy link

SparkQA commented Jul 26, 2016

Test build #62882 has finished for PR 14348 at commit fd03d40.

  • This patch fails Spark unit tests.
  • This patch merges cleanly.
  • This patch adds no public classes.

@srowen
Copy link
Member

srowen commented Jul 26, 2016

Jenkins retest this please

@SparkQA
Copy link

SparkQA commented Jul 26, 2016

Test build #62887 has finished for PR 14348 at commit fd03d40.

  • This patch passes all tests.
  • This patch merges cleanly.
  • This patch adds no public classes.

@srowen
Copy link
Member

srowen commented Jul 26, 2016

LGTM. This addresses the compilation error observed in the last PR. Let's try merging to master again.

@asfgit asfgit closed this in 0869b3a Jul 26, 2016
mgummelt pushed a commit to d2iq-archive/spark that referenced this pull request Aug 2, 2016
## What changes were proposed in this pull request?

(Please fill in changes proposed in this fix)

## How was this patch tested?

(Please explain how this patch was tested. E.g. unit tests, integration tests, manual tests)

(If this patch involves UI changes, please attach a screenshot; otherwise, remove this)

Mesos agents by default will not pull docker images which are cached
locally already. In order to run Spark executors from mutable tags like
`:latest` this commit introduces a Spark setting
(`spark.mesos.executor.docker.forcePullImage`). Setting this flag to
true will tell the Mesos agent to force pull the docker image (default is `false` which is consistent with the previous
implementation and Mesos' default
behaviour).

Author: Philipp Hoffmann <mail@philipphoffmann.de>

Closes apache#14348 from philipphoffmann/force-pull-image.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants