Skip to content

[SPARK-16715][Tests]Fix a potential ExprId conflict for SubexpressionEliminationSuite."Semantic equals and hash" #14350

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
zsxwing wants to merge 1 commit into from
Closed

[SPARK-16715][Tests]Fix a potential ExprId conflict for SubexpressionEliminationSuite."Semantic equals and hash" #14350

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 5 additions & 1 deletion .../test/scala/org/apache/spark/sql/catalyst/expressions/SubexpressionEliminationSuite.scala
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -21,8 +21,12 @@ import org.apache.spark.sql.types.IntegerType

class SubexpressionEliminationSuite extends SparkFunSuite {
test("Semantic equals and hash") {
val id = ExprId(1)
val a: AttributeReference = AttributeReference("name", IntegerType)()
val id = {
// Make sure we use a "ExprId" different from "a.exprId"
val _id = ExprId(1)
if (a.exprId == _id) ExprId(2) else _id
}
val b1 = a.withName("name2").withExprId(id)
val b2 = a.withExprId(id)
val b3 = a.withQualifier(Some("qualifierName"))
Expand Down