[SPARK-16722][Tests]Fix a StreamingContext leak in StreamingContextSuite when eventually fails #14354
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| eventually(timeout(10000 millis)) { | ||
| assert(Checkpoint.getCheckpointFiles(checkpointDirectory).size > 1) | ||
| try { | ||
| eventually(timeout(30000 millis)) { |
Member
Author
There was a problem hiding this comment.
I also increased this one to 30 seconds in case the Jenkins worker is pretty busy.
Member
Author
|
This is an example of this leak: http://spark-tests.appspot.com/builds/spark-master-test-sbt-hadoop-2.2/1429 |
Contributor
|
LGTM. |
|
Test build #62849 has finished for PR 14354 at commit
|
Contributor
|
Merging to master and 2.0 |
asfgit
pushed a commit
that referenced
this pull request
Jul 26, 2016
…uite when eventually fails ## What changes were proposed in this pull request? This PR moves `ssc.stop()` into `finally` for `StreamingContextSuite.createValidCheckpoint` to avoid leaking a StreamingContext since leaking a StreamingContext will fail a lot of tests and make us hard to find the real failure one. ## How was this patch tested? Jenkins unit tests Author: Shixiong Zhu <shixiong@databricks.com> Closes #14354 from zsxwing/ssc-leak. (cherry picked from commit e164a04) Signed-off-by: Tathagata Das <tathagata.das1565@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
This PR moves
ssc.stop()intofinallyforStreamingContextSuite.createValidCheckpointto avoid leaking a StreamingContext since leaking a StreamingContext will fail a lot of tests and make us hard to find the real failure one.How was this patch tested?
Jenkins unit tests