[SPARK-16750] [Follow-up] [ML] Add transformSchema for StringIndexer/VectorAssembler and fix failed tests. #14455
+16
−5
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Test build #63113 has finished for PR 14455 at commit
|
Contributor
Author
Member
|
OK, add SPARK-16750 in the title |
yanboliang
changed the title
Contributor
Author
|
@srowen Added. Thanks! |
Member
|
Merged to master/2.0 also |
asfgit
pushed a commit
that referenced
this pull request
Aug 5, 2016
…ctorAssembler and fix failed tests. ## What changes were proposed in this pull request? This is follow-up for #14378. When we add ```transformSchema``` for all estimators and transformers, I found there are tests failed for ```StringIndexer``` and ```VectorAssembler```. So I moved these parts of work separately in this PR, to make it more clear to review. The corresponding tests should throw ```IllegalArgumentException``` at schema validation period after we add ```transformSchema```. It's efficient that to throw exception at the start of ```fit``` or ```transform``` rather than during the process. ## How was this patch tested? Modified unit tests. Author: Yanbo Liang <ybliang8@gmail.com> Closes #14455 from yanboliang/transformSchema. (cherry picked from commit 6cbde33) Signed-off-by: Sean Owen <sowen@cloudera.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
This is follow-up for #14378. When we add
transformSchemafor all estimators and transformers, I found there are tests failed forStringIndexerandVectorAssembler. So I moved these parts of work separately in this PR, to make it more clear to review.The corresponding tests should throw
IllegalArgumentExceptionat schema validation period after we addtransformSchema. It's efficient that to throw exception at the start offitortransformrather than during the process.How was this patch tested?
Modified unit tests.