[SPARK-16796][Web UI] Mask spark.authenticate.secret on Spark environ… #14484
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
||
| private def removePass(kv: (String, String)): (String, String) = { | ||
| if (kv._1.toLowerCase.contains("password")) (kv._1, "******") else kv | ||
| if (kv._1.toLowerCase.contains("password") || propertiesToMask.contains(kv._1.toLowerCase)) { |
Member
There was a problem hiding this comment.
Are we sure we don't want to mask every property with the word secret like we did with password?
Contributor
Author
|
@srowen @ajbozarth Yep, more properties with |
Contributor
Author
|
@srowen Can you verify the patch? |
Member
|
Jenkins test this please |
|
Test build #63280 has finished for PR 14484 at commit
|
Member
|
Merged to master |
asfgit
pushed a commit
that referenced
this pull request
Nov 2, 2016
## What changes were proposed in this pull request? Mask `spark.authenticate.secret` on Spark environment page (Web UI). This is addition to #14409 ## How was this patch tested? `./dev/run-tests` [info] ScalaTest [info] Run completed in 1 hour, 8 minutes, 38 seconds. [info] Total number of tests run: 2166 [info] Suites: completed 65, aborted 0 [info] Tests: succeeded 2166, failed 0, canceled 0, ignored 590, pending 0 [info] All tests passed. Author: Artur Sukhenko <artur.sukhenko@gmail.com> Closes #14484 from Devian-ua/SPARK-16796. (cherry picked from commit 14dba45) Signed-off-by: Sean Owen <sowen@cloudera.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
Mask
spark.authenticate.secreton Spark environment page (Web UI).This is addition to #14409
How was this patch tested?
./dev/run-tests[info] ScalaTest
[info] Run completed in 1 hour, 8 minutes, 38 seconds.
[info] Total number of tests run: 2166
[info] Suites: completed 65, aborted 0
[info] Tests: succeeded 2166, failed 0, canceled 0, ignored 590, pending 0
[info] All tests passed.