[SPARK-16826][SQL] Switch to java.net.URI for parse_url() #14488
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
Author
|
Grr, looks like I pushed an extra commit (in HashedRelation.scala). Should I rebase? |
Contributor
|
Can you make the JIRA description self-contained? It makes it much easier to understand commits. Thanks. |
Contributor
Author
|
@rxin is that better? |
Member
|
Description looks good. You can use |
Contributor
Author
|
rebase done! |
| new URI(url.toString) | ||
| } catch { | ||
| case e: MalformedURLException => null | ||
| case e: URISyntaxException => null |
Member
There was a problem hiding this comment.
Don't change this unless you need to make another change anyway, but this can be case _: ... I know it wasn't like that before
Member
|
Jenkins test this please |
|
Test build #63265 has finished for PR 14488 at commit
|
Member
|
LGTM, that does fix a fairly important bottleneck for anyone doing URL parsing. |
Member
|
Merged to master |
Contributor
Author
|
Thanks a lot! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
The java.net.URL class has a globally synchronized Hashtable, which limits the throughput of any single executor doing lots of calls to parse_url(). Tests have shown that a 36-core machine can only get to 10% CPU use because the threads are locked most of the time.
This patch switches to java.net.URI which has less features than java.net.URL but focuses on URI parsing, which is enough for parse_url().
New tests were added to make sure a few common edge cases didn't change behaviour.
https://issues.apache.org/jira/browse/SPARK-16826
How was this patch tested?
I've kept the old URL code commented for now, so that people can verify that the new unit tests do pass with java.net.URL.
Thanks to @srowen for the help!