Skip to content

Conversation

@nchammas
Copy link
Contributor

@nchammas nchammas commented Aug 4, 2016

Proposed Changes

  • Update the list of "important classes" in pyspark.sql to match 2.0.
  • Fix references to UDFRegistration so that the class shows up in the docs. It currently doesn't.
  • Remove some unnecessary whitespace in the Python RST doc files.

I reused the existing JIRA I created last week for similar API doc fixes.

How was this patch tested?

  • I ran lint-python successfully.
  • I ran make clean build on the Python docs and confirmed the results are as expected locally in my browser.

@SparkQA
Copy link

SparkQA commented Aug 4, 2016

Test build #63231 has finished for PR 14496 at commit 62f4f82.

  • This patch passes all tests.
  • This patch merges cleanly.
  • This patch adds no public classes.

@nchammas
Copy link
Contributor Author

nchammas commented Aug 4, 2016

cc @rxin - Follow-on to #14393.

asfgit pushed a commit that referenced this pull request Aug 6, 2016
… + Update "important classes"

## Proposed Changes

* Update the list of "important classes" in `pyspark.sql` to match 2.0.
* Fix references to `UDFRegistration` so that the class shows up in the docs. It currently [doesn't](http://spark.apache.org/docs/latest/api/python/pyspark.sql.html).
* Remove some unnecessary whitespace in the Python RST doc files.

I reused the [existing JIRA](https://issues.apache.org/jira/browse/SPARK-16772) I created last week for similar API doc fixes.

## How was this patch tested?

* I ran `lint-python` successfully.
* I ran `make clean build` on the Python docs and confirmed the results are as expected locally in my browser.

Author: Nicholas Chammas <nicholas.chammas@gmail.com>

Closes #14496 from nchammas/SPARK-16772-UDFRegistration.

(cherry picked from commit 2dd0388)
Signed-off-by: Sean Owen <sowen@cloudera.com>
@srowen
Copy link
Member

srowen commented Aug 6, 2016

Merged to master/2.0

@asfgit asfgit closed this in 2dd0388 Aug 6, 2016
@nchammas
Copy link
Contributor Author

nchammas commented Aug 6, 2016

Thanks @srowen. 👍

@nchammas nchammas deleted the SPARK-16772-UDFRegistration branch August 7, 2016 22:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants