Skip to content

Conversation

@avulanov
Copy link
Contributor

This PR contains the adaptation of #13868 for Spark 2.0

What changes were proposed in this pull request?

Fix the construction of the file path in SQLConf.scala and unit tests that rely on this: SQLConfSuite and DDLSuite. Previous way of construction caused the creation of incorrect path on Windows.

How was this patch tested?

Run unit tests on Windows

@srowen
Copy link
Member

srowen commented Aug 11, 2016

Jenkins test this please

@SparkQA
Copy link

SparkQA commented Aug 11, 2016

Test build #63604 has finished for PR 14600 at commit 2f4566c.

  • This patch passes all tests.
  • This patch merges cleanly.
  • This patch adds no public classes.

@srowen
Copy link
Member

srowen commented Aug 11, 2016

Thanks @avulanov for the follow up. Merging to 2.0

asfgit pushed a commit that referenced this pull request Aug 11, 2016
…Path for Spark 2.0

This PR contains the adaptation of #13868 for Spark 2.0

## What changes were proposed in this pull request?

Fix the construction of the file path in `SQLConf.scala` and unit tests that rely on this: `SQLConfSuite` and `DDLSuite`. Previous way of construction caused the creation of incorrect path on Windows.

## How was this patch tested?

Run unit tests on Windows

Author: avulanov <nashb@yandex.ru>

Closes #14600 from avulanov/SPARK-15899-file-2.0.
@tOverney
Copy link

When can we expect a spark release with those changes incorporated?

@srowen
Copy link
Member

srowen commented Aug 11, 2016

You can take a look at the JIRA -- would be in 2.0.1 or 2.1.0 whichever comes first. It could be a month or two before one of those happens. There's a workaround in the JIRA though.

@Praveenmail2him
Copy link

Can anyone post the sample usage for this exception in Spark 2.0, I'm still facing this exception?

@HyukjinKwon
Copy link
Member

@srowen Do you mind if I ask this is supposed to be closed (as it is merged into 2.0)?

@srowen
Copy link
Member

srowen commented Sep 21, 2016

Yes @avulanov can you close it? we can't close it directly and the bot can only close PRs opened vs master.

Copy link

@Praveenmail2him Praveenmail2him left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It is fixed.

@avulanov avulanov closed this Sep 21, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants