Skip to content

Conversation

@zenglinxi0615
Copy link

What changes were proposed in this pull request?

make spark sql compatible with hive sql that using python script transform like using 'xxx.py'

How was this patch tested?

manual tests

… python script transform like using 'xxx.py'
@AmplabJenkins
Copy link

Can one of the admins verify this patch?

// for compatibility with hive
// if the script is a python/bash/... file, we should make it executable
if (new File(script).exists) {
new File(script).setExecutable(true)
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Doesn't this create a huge security hole? Especially because we are not resetting this to its old state.

@zenglinxi0615
Copy link
Author

Have you tried it on spark 1.6.2?

@yongliangliu
Copy link

yongliangliu commented Aug 19, 2016

I know how to deal with it.
i used the fllow code like this

add file /temp/test.py;
select transform(var1) using '/temp/test.py' as (var1_new)  from test_table;

the error is "Error: /bin/bash: test.py: command not found"
but when i use this and do not change the source code ,it's work,i was so stupid.

add file /temp/test.py;
select transform(var1) using 'python /temp/test.py' as (var1_new)  from test_table;

so there is not bug and no need to change source code

@zenglinxi0615
Copy link
Author

zenglinxi0615 commented Sep 1, 2016

sorry for long time no response.
yes, you are right, when you can change the sql from using '/temp/test.py' to using 'python /temp/test.py', there's no need for changing the spark source code.
However, this patch is used for the case when there are already many hive sql which using '/temp/test.py', it cost too much time for modifing these hive sql, so we want to make spark sql compatible with hive sql that using python script transform like using 'xxx.py'.

@HyukjinKwon
Copy link
Member

@zenglinxi0615 Is it still active? I wonder if there is any argument against #14686 (comment). Otherwise, I would rather like to suggest to close this.

@asfgit asfgit closed this in 5d2750a May 18, 2017
zifeif2 pushed a commit to zifeif2/spark that referenced this pull request Nov 22, 2025
## What changes were proposed in this pull request?

This PR proposes to close PRs ...

  - inactive to the review comments more than a month
  - WIP and inactive more than a month
  - with Jenkins build failure but inactive more than a month
  - suggested to be closed and no comment against that
  - obviously looking inappropriate (e.g., Branch 0.5)

To make sure, I left a comment for each PR about a week ago and I could not have a response back from the author in these PRs below:

Closes apache#11129
Closes apache#12085
Closes apache#12162
Closes apache#12419
Closes apache#12420
Closes apache#12491
Closes apache#13762
Closes apache#13837
Closes apache#13851
Closes apache#13881
Closes apache#13891
Closes apache#13959
Closes apache#14091
Closes apache#14481
Closes apache#14547
Closes apache#14557
Closes apache#14686
Closes apache#15594
Closes apache#15652
Closes apache#15850
Closes apache#15914
Closes apache#15918
Closes apache#16285
Closes apache#16389
Closes apache#16652
Closes apache#16743
Closes apache#16893
Closes apache#16975
Closes apache#17001
Closes apache#17088
Closes apache#17119
Closes apache#17272
Closes apache#17971

Added:
Closes apache#17778
Closes apache#17303
Closes apache#17872

## How was this patch tested?

N/A

Author: hyukjinkwon <gurwls223@gmail.com>

Closes apache#18017 from HyukjinKwon/close-inactive-prs.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants