-
Notifications
You must be signed in to change notification settings - Fork 29k
[SPARK-16253][SQL] make spark sql compatible with hive sql that using… #14686
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
… python script transform like using 'xxx.py'
|
Can one of the admins verify this patch? |
| // for compatibility with hive | ||
| // if the script is a python/bash/... file, we should make it executable | ||
| if (new File(script).exists) { | ||
| new File(script).setExecutable(true) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Doesn't this create a huge security hole? Especially because we are not resetting this to its old state.
|
Have you tried it on spark 1.6.2? |
|
I know how to deal with it. the error is "Error: /bin/bash: test.py: command not found" so there is not bug and no need to change source code |
|
sorry for long time no response. |
|
@zenglinxi0615 Is it still active? I wonder if there is any argument against #14686 (comment). Otherwise, I would rather like to suggest to close this. |
## What changes were proposed in this pull request? This PR proposes to close PRs ... - inactive to the review comments more than a month - WIP and inactive more than a month - with Jenkins build failure but inactive more than a month - suggested to be closed and no comment against that - obviously looking inappropriate (e.g., Branch 0.5) To make sure, I left a comment for each PR about a week ago and I could not have a response back from the author in these PRs below: Closes apache#11129 Closes apache#12085 Closes apache#12162 Closes apache#12419 Closes apache#12420 Closes apache#12491 Closes apache#13762 Closes apache#13837 Closes apache#13851 Closes apache#13881 Closes apache#13891 Closes apache#13959 Closes apache#14091 Closes apache#14481 Closes apache#14547 Closes apache#14557 Closes apache#14686 Closes apache#15594 Closes apache#15652 Closes apache#15850 Closes apache#15914 Closes apache#15918 Closes apache#16285 Closes apache#16389 Closes apache#16652 Closes apache#16743 Closes apache#16893 Closes apache#16975 Closes apache#17001 Closes apache#17088 Closes apache#17119 Closes apache#17272 Closes apache#17971 Added: Closes apache#17778 Closes apache#17303 Closes apache#17872 ## How was this patch tested? N/A Author: hyukjinkwon <gurwls223@gmail.com> Closes apache#18017 from HyukjinKwon/close-inactive-prs.
What changes were proposed in this pull request?
make spark sql compatible with hive sql that using python script transform like using 'xxx.py'
How was this patch tested?
manual tests