[SPARK-17257][SQL] the physical plan of CREATE TABLE or CTAS should take CatalogTable #14823
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
Author
|
Test build #64461 has finished for PR 14823 at commit
|
|
Test build #64525 has finished for PR 14823 at commit
|
Member
|
I missed this ping. Will review it tomorrow. |
| // TODO: this may be wrong for non file-based data source like JDBC, which should be external | ||
| // even there is no `path` in options. We should consider allow the EXTERNAL keyword. | ||
| val tableType = if (new CaseInsensitiveMap(options).contains("path")) { | ||
| CatalogTableType.EXTERNAL |
Member
There was a problem hiding this comment.
After this PR, it becomes much clear to users. We can support Create External Data Source Table! We just need to confirm the path is provided.
Contributor
Author
There was a problem hiding this comment.
removing this means we change the syntax, I'd like to avoid it in this PR, and that's why I leave this TODO here, we can do it in follow-up
Member
|
LGTM except one minor comment. |
|
Test build #64759 has finished for PR 14823 at commit
|
cloud-fan
force-pushed
the
create-table
branch
from
00bf25b to
52a40d9
Compare
|
Test build #64762 has finished for PR 14823 at commit
|
Contributor
Author
|
thanks for the review, merging to master! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
This is kind of a follow-up of #14482 . As we put
CatalogTablein the logical plan directly, it makes sense to let physical plans takeCatalogTabledirectly, instead of extracting some fields ofCatalogTablein planner and then construct a newCatalogTablein physical plan.How was this patch tested?
existing tests.