[ML][MLLIB]The require condition and message doesn't match in SparseMatrix. #14824
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Test build #64463 has finished for PR 14824 at commit
|
| require(colPtrs.length == numCols + 1 || colPtrs.length == numRows + 1, "The length of the " + | ||
| "column indices should be the number of columns + 1. Currently, colPointers.length: " + | ||
| s"${colPtrs.length}, numCols: $numCols") | ||
| require(!isTransposed && colPtrs.length == numCols + 1 || |
Member
There was a problem hiding this comment.
This may be clearer if you just have two clauses:
if (isTransposed) {
require(...)
} else {
require(...)
}
That lets you write a shorter specific message in both cases.
added 2 commits
August 26, 2016 21:23
| "column indices should be the number of columns + 1. Currently, colPointers.length: " + | ||
| s"${colPtrs.length}, numCols: $numCols") | ||
| if (isTransposed) { | ||
| require(colPtrs.length == numRows + 1, "The length of the column indices should be " + |
Member
There was a problem hiding this comment.
I think our style would be to indent subsequent lines in a continuation. You might just simplify these messages to something like
require(...,
s"Expecting ${numRows + 1} colPtrs when numRows = $numRows but got ${colPtrs.length}")
added 2 commits
August 26, 2016 21:46
|
Test build #64480 has finished for PR 14824 at commit
|
|
Test build #64481 has finished for PR 14824 at commit
|
|
Test build #64483 has finished for PR 14824 at commit
|
|
Test build #64484 has finished for PR 14824 at commit
|
asfgit
pushed a commit
that referenced
this pull request
Aug 27, 2016
…Matrix. ## What changes were proposed in this pull request? The require condition and message doesn't match, and the condition also should be optimized. Small change. Please kindly let me know if JIRA required. ## How was this patch tested? No additional test required. Author: Peng, Meng <peng.meng@intel.com> Closes #14824 from mpjlu/smallChangeForMatrixRequire. (cherry picked from commit 40168db) Signed-off-by: Sean Owen <sowen@cloudera.com>
Member
|
Merged to master/2.0 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
The require condition and message doesn't match, and the condition also should be optimized.
Small change. Please kindly let me know if JIRA required.
How was this patch tested?
No additional test required.