[SPARK-17303] Added spark-warehouse to dev/.rat-excludes #14870
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
|
Jenkins, this is ok to test. |
Contributor
|
LGTM |
|
Test build #64608 has finished for PR 14870 at commit
|
Contributor
|
Merged to master. Thanks! |
| .*\.sql | ||
| .Rbuildignore | ||
| org.apache.spark.deploy.yarn.security.ServiceCredentialProvider | ||
| spark-warehouse |
Member
There was a problem hiding this comment.
@frreiss this seems fine but better still is to understand what's leaving this lying around. You can see all the debris that various tests have been leaving around by looking at this file by somewhere just doing a new File("mytestdir")
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
Excludes the
spark-warehousedirectory from the Apache RAT checks that src/run-tests performs.spark-warehouseis created by some of the Spark SQL tests, as well as bybin/spark-sql.How was this patch tested?
Ran src/run-tests twice. The second time, the script failed because the first iteration
Made the change in this PR.
Ran src/run-tests a third time; RAT checks succeeded.