[SPARK-17388][SQL] Support for inferring type date/timestamp/decimal for partition column #14947
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
Author
|
Some tests might be failed due to #14919. |
|
Test build #64893 has finished for PR 14947 at commit
|
Member
Author
There was a problem hiding this comment.
IIUC, decimal is not being inferred before.
Member
Author
|
Hi @davies , it seems you made some changes related with this before. Could you please take a look? |
|
Test build #65219 has finished for PR 14947 at commit
|
HyukjinKwon
changed the title
Member
Author
There was a problem hiding this comment.
Ah, I think I should check this requirement. I will update the description soon too.
Member
Author
There was a problem hiding this comment.
Checked and I added some more end-to-end tests.
HyukjinKwon
changed the title
|
Test build #65234 has finished for PR 14947 at commit
|
Member
Author
|
ping @davies |
Member
Author
|
gentle ping @davies |
Member
Author
|
@davies I can just remove the decimal change here if you are uncertain of this. |
Member
Author
|
ping @davies .. |
Contributor
|
LGTM |
Member
Author
|
Thanks @davies. (I forgot to push the commits.) |
HyukjinKwon
force-pushed
the
SPARK-17388
branch
from
e9dea77 to
bd5a63d
Compare
|
Test build #67131 has finished for PR 14947 at commit
|
Contributor
|
Merging this into master, thanks! |
robert3005
pushed a commit
to palantir/spark
that referenced
this pull request
Nov 1, 2016
… for partition column ## What changes were proposed in this pull request? Currently, Spark only supports to infer `IntegerType`, `LongType`, `DoubleType` and `StringType`. `DecimalType` is being tried but it seems it never infers type as `DecimalType` as `DoubleType` is being tried first. Also, it seems `DateType` and `TimestampType` could be inferred. As far as I know, it is pretty common to use both for a partition column. This PR fixes the incorrect `DecimalType` try and also adds the support for both `DateType` and `TimestampType` for inferring partition column type. ## How was this patch tested? Unit tests in `ParquetPartitionDiscoverySuite`. Author: hyukjinkwon <gurwls223@gmail.com> Closes apache#14947 from HyukjinKwon/SPARK-17388.
uzadude
pushed a commit
to uzadude/spark
that referenced
this pull request
Jan 27, 2017
… for partition column ## What changes were proposed in this pull request? Currently, Spark only supports to infer `IntegerType`, `LongType`, `DoubleType` and `StringType`. `DecimalType` is being tried but it seems it never infers type as `DecimalType` as `DoubleType` is being tried first. Also, it seems `DateType` and `TimestampType` could be inferred. As far as I know, it is pretty common to use both for a partition column. This PR fixes the incorrect `DecimalType` try and also adds the support for both `DateType` and `TimestampType` for inferring partition column type. ## How was this patch tested? Unit tests in `ParquetPartitionDiscoverySuite`. Author: hyukjinkwon <gurwls223@gmail.com> Closes apache#14947 from HyukjinKwon/SPARK-17388.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
Currently, Spark only supports to infer
IntegerType,LongType,DoubleTypeandStringType.DecimalTypeis being tried but it seems it never infers type asDecimalTypeasDoubleTypeis being tried first. Also, it seemsDateTypeandTimestampTypecould be inferred.As far as I know, it is pretty common to use both for a partition column.
This PR fixes the incorrect
DecimalTypetry and also adds the support for bothDateTypeandTimestampTypefor inferring partition column type.How was this patch tested?
Unit tests in
ParquetPartitionDiscoverySuite.