Skip to content

Correct fetchsize property name in docs #14975

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
darabos wants to merge 2 commits into from
Closed

Correct fetchsize property name in docs #14975

darabos wants to merge 2 commits into from

Conversation

@darabos
Copy link
Contributor

@darabos darabos commented Sep 6, 2016

What changes were proposed in this pull request?

Replace fetchSize with fetchsize in the docs.

How was this patch tested?

I manually tested fetchSize and fetchsize. The latter has an effect. See also JdbcUtils.scala#L38 for the definition of the property.

@darabos
Correct fetchsize property name.
6607dec 
Property is defined at JdbcUtils.scala#L38.
@srowen
Copy link
Member

srowen commented Sep 6, 2016

+1. There are other occurrences of "FetchSize" or "fetchSize" in the code, though none will matter for users (i.e. test names). But feel free to fix them.

@darabos
Copy link
Contributor Author

darabos commented Sep 8, 2016

+1. There are other occurrences of "FetchSize" or "fetchSize" in the code, though none will matter for users (i.e. test names). But feel free to fix them.

Good point! I'll update the pull request next week. (Sorry for the delay.)

@srowen
Copy link
Member

srowen commented Sep 15, 2016

@darabos do you want to close this out or should I do the update?

@darabos
Copy link
Contributor Author

darabos commented Sep 16, 2016

@darabos do you want to close this out or should I do the update?

Sorry! I'll try to do it tonight. If I don't report back, consider me eaten by a monster.

@darabos
Copy link
Contributor Author

darabos commented Sep 16, 2016

+1. There are other occurrences of "FetchSize" or "fetchSize" in the code, though none will matter for users (i.e. test names). But feel free to fix them.

Done.

@SparkQA
Copy link

SparkQA commented Sep 17, 2016

Test build #3278 has finished for PR 14975 at commit f820ea2.

  • This patch passes all tests.
  • This patch merges cleanly.
  • This patch adds no public classes.

@srowen
Copy link
Member

srowen commented Sep 17, 2016

Merged to master/2.0

asfgit pushed a commit that referenced this pull request Sep 17, 2016
@darabos @srowen
Correct fetchsize property name in docs
9ff158b 
## What changes were proposed in this pull request?

Replace `fetchSize` with `fetchsize` in the docs.

## How was this patch tested?

I manually tested `fetchSize` and `fetchsize`. The latter has an effect. See also [`JdbcUtils.scala#L38`](https://github.com/apache/spark/blob/v2.0.0/sql/core/src/main/scala/org/apache/spark/sql/execution/datasources/jdbc/JdbcUtils.scala#L38) for the definition of the property.

Author: Daniel Darabos <darabos.daniel@gmail.com>

Closes #14975 from darabos/patch-3.

(cherry picked from commit 69cb049)
Signed-off-by: Sean Owen <sowen@cloudera.com>
@asfgit asfgit closed this in 69cb049 Sep 17, 2016
@darabos darabos deleted the patch-3 branch September 19, 2016 13:11
wgtmac pushed a commit to wgtmac/spark that referenced this pull request Sep 19, 2016
@darabos @wgtmac
Correct fetchsize property name in docs
19f894e 
## What changes were proposed in this pull request?

Replace `fetchSize` with `fetchsize` in the docs.

## How was this patch tested?

I manually tested `fetchSize` and `fetchsize`. The latter has an effect. See also [`JdbcUtils.scala#L38`](https://github.com/apache/spark/blob/v2.0.0/sql/core/src/main/scala/org/apache/spark/sql/execution/datasources/jdbc/JdbcUtils.scala#L38) for the definition of the property.

Author: Daniel Darabos <darabos.daniel@gmail.com>

Closes apache#14975 from darabos/patch-3.
zzcclp added a commit to zzcclp/spark that referenced this pull request Sep 20, 2016
@zzcclp
[EXT]Correct fetchsize property name in docs apache#14975
bd3a4cd
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@darabos @srowen @SparkQA