Skip to content

[SPARK-17425][SQL] Override sameResult in HiveTableScanExec to make ReuseExchange work in text format table #14988

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
watermen wants to merge 1 commit into from
Closed

[SPARK-17425][SQL] Override sameResult in HiveTableScanExec to make ReuseExchange work in text format table #14988

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
15 changes: 15 additions & 0 deletions sql/hive/src/main/scala/org/apache/spark/sql/hive/execution/HiveTableScanExec.scala
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -164,4 +164,19 @@ case class HiveTableScanExec(
}

override def output: Seq[Attribute] = attributes

override def sameResult(plan: SparkPlan): Boolean = plan match {
Copy link
Contributor

@cloud-fan cloud-fan Sep 7, 2016

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

why the default one doesn't work?

Copy link
Contributor Author

@watermen watermen Sep 7, 2016

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

left.cleanArgs == right.cleanArgs in defalut sameResult return false, because equals in MetastoreRelation compare the output(AttributeReference) and exprIds are diff. We need to erase the exprId.

Copy link
Contributor

@cloud-fan cloud-fan Sep 7, 2016

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ah, I think all leaf nodes suffer this problem, can you follow the way how they fix it? e.g.

  override def sameResult(plan: LogicalPlan): Boolean = {
    plan.canonicalized match {
      case LocalRelation(otherOutput, otherData) =>
        otherOutput.map(_.dataType) == output.map(_.dataType) && otherData == data
      case _ => false
    }
  }

Copy link
Contributor Author

@watermen watermen Sep 12, 2016 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ReuseExchange work in parquet/orc format, because FileSourceScanExec has override the sameResult.

case other: HiveTableScanExec =>
val thisPredicates = partitionPruningPred.map(cleanExpression)
val otherPredicates = other.partitionPruningPred.map(cleanExpression)

val result = relation.sameResult(other.relation) &&
output.length == other.output.length &&
output.zip(other.output)
.forall(p => p._1.name == p._2.name && p._1.dataType == p._2.dataType) &&
Copy link
Contributor

@cloud-fan cloud-fan Sep 20, 2016

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

does the name matter? I'm not quite sure, but LogicalRelation only checks data type

Copy link
Contributor Author

@watermen watermen Sep 20, 2016 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

For example, the full output of table src is (key: Int, value: Int), and output1 is (key: Int), output2 is (value: Int), their(output1, output2) dataType are same, but they are diff and can't be resued.

Copy link
Contributor Author

@watermen watermen Sep 22, 2016

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@cloud-fan

thisPredicates.length == otherPredicates.length &&
thisPredicates.zip(otherPredicates).forall(p => p._1.semanticEquals(p._2))
result
case _ => false
}
}