[SQL][SPARK-17439] Fixing compression issues with approximate quantiles and adding more tests #15002
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
Author
|
cc @clockfly |
thunterdb
changed the title
| // If necessary, add the minimum element: | ||
| res.prepend(currentSamples.head) | ||
| val currHead = currentSamples.head | ||
| if (currHead.value < head.value) { |
|
Test build #65056 has finished for PR 15002 at commit
|
Member
|
This seems fine to me, and would also fix SPARK-17306. You can note that in the title. I'm closing #14976 |
Member
|
Merged to master and to 2.0 with some conflict resolution |
asfgit
pushed a commit
that referenced
this pull request
Sep 11, 2016
…es and adding more tests This PR build on #14976 and fixes a correctness bug that would cause the wrong quantile to be returned for small target errors. This PR adds 8 unit tests that were failing without the fix. Author: Timothy Hunter <timhunter@databricks.com> Author: Sean Owen <sowen@cloudera.com> Closes #15002 from thunterdb/ml-1783. (cherry picked from commit 180796e) Signed-off-by: Sean Owen <sowen@cloudera.com>
Contributor
Author
|
Thank you @srowen |
wgtmac
pushed a commit
to wgtmac/spark
that referenced
this pull request
Sep 19, 2016
…es and adding more tests ## What changes were proposed in this pull request? This PR build on apache#14976 and fixes a correctness bug that would cause the wrong quantile to be returned for small target errors. ## How was this patch tested? This PR adds 8 unit tests that were failing without the fix. Author: Timothy Hunter <timhunter@databricks.com> Author: Sean Owen <sowen@cloudera.com> Closes apache#15002 from thunterdb/ml-1783.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
This PR build on #14976 and fixes a correctness bug that would cause the wrong quantile to be returned for small target errors.
How was this patch tested?
This PR adds 8 unit tests that were failing without the fix.