[SPARKR][SPARK-17442] Additional arguments in write.df are not passed to data source #15007
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Test build #65065 has finished for PR 15007 at commit
|
R/pkg/R/DataFrame.R
Outdated
| write <- callJMethod(write, "format", source) | ||
| write <- callJMethod(write, "mode", jmode) | ||
| write <- callJMethod(write, "save", path) | ||
| write <- callJMethod(write, "save", options) |
Contributor
There was a problem hiding this comment.
I am not sure I see a save method which takes in options. What if we just call write <- callJMethod(write, "options", options) in the line before write <- callJMethod(write, "save", path) ?
Member
There was a problem hiding this comment.
oops, sorry I broke it.
right, I think the right approach is
write <- callJMethod(write, "options", options)
write <- callJMethod(write, "save", path)
save should be the last call.
|
Test build #65067 has finished for PR 15007 at commit
|
| csvPath2 <- tempfile(pattern = "csvtest2", fileext = ".csv") | ||
| write.df(df2, path = csvPath2, "csv", header = "true") | ||
| df3 <- read.df(csvPath2, "csv", header = "true") | ||
| exect_equal(nrow(df3), nrow(df2)) |
Member
|
sorry for the trouble, I opened #15010 with the fix |
|
Test build #65078 has finished for PR 15007 at commit
|
Contributor
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
additional options were not passed down in
write.df. This patch fixes thatHow was this patch tested?
Adds unit test for passing
header = "true"for CSV data source in R unit tests