Skip to content

[SPARK-16445][MLlib][SparkR] Fix @return description for sparkR mlp summary() method #15015

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
keypointt wants to merge 3 commits into from
Closed

[SPARK-16445][MLlib][SparkR] Fix @return description for sparkR mlp summary() method #15015

keypointt wants to merge 3 commits into from

Conversation

@keypointt
Copy link
Contributor

@keypointt keypointt commented Sep 8, 2016

What changes were proposed in this pull request?

Fix summary() method's @return description for spark.mlp

How was this patch tested?

Ran tests locally on my laptop.

@SparkQA
Copy link

SparkQA commented Sep 8, 2016

Test build #65110 has finished for PR 15015 at commit 99d8944.

  • This patch passes all tests.
  • This patch merges cleanly.
  • This patch adds no public classes.

@keypointt
Copy link
Contributor Author

keypointt commented Sep 8, 2016

hi @felixcheung this is just a minor patch to SPARK-16445, where the @return description is not accurate and fixed here. Do you mind have a look here? Thanks a lot :)

felixcheung
felixcheung reviewed Sep 8, 2016
View reviewed changes
R/pkg/R/mllib.R
labelCount <- callJMethod(jobj, "labelCount")
layers <- unlist(callJMethod(jobj, "layers"))
weights <- callJMethod(jobj, "weights")
weights <- matrix(weights, nrow = length(weights))
Copy link
Member

@felixcheung felixcheung Sep 8, 2016

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

could we add a test for this output?

@felixcheung
Copy link
Member

felixcheung commented Sep 8, 2016

cool thanks, just one comment

@keypointt
Copy link
Contributor Author

keypointt commented Sep 8, 2016

There is already a test expect_equal(length(summary$weights), 64)
https://github.com/apache/spark/blob/master/R/pkg/inst/tests/testthat/test_mllib.R#L371

is it enough or we should add more tests?

@felixcheung
Copy link
Member

felixcheung commented Sep 8, 2016

since the format of the output is changing it would be great to check more than just the length in test

@keypointt
Copy link
Contributor Author

keypointt commented Sep 8, 2016

how about adding type check? expect_equal(typeof(summary$weights), "list")

@HyukjinKwon
Copy link
Member

HyukjinKwon commented Sep 9, 2016 •
edited
Loading

@felixcheung I think this is a irrelevant comment but is there any issue for enabling Windows test for now? It seems it should have run a test for this PR.

@felixcheung
Copy link
Member

felixcheung commented Sep 9, 2016

@keypointt let's have a check for the first few values perhaps?
@HyukjinKwon It seems it would be good to start running R tests though I'm not sure actually - I'd defer to @shivaram

@shivaram
Copy link
Contributor

shivaram commented Sep 9, 2016

@HyukjinKwon I thought it should have run the tests ? Any ideas why its not getting picked up ? Is there some other set of steps that we need to do ? (I'm now investigating how it works for Apache Thrift)

@shivaram
Copy link
Contributor

shivaram commented Sep 9, 2016

I think we need to file an INFRA ticket like https://issues.apache.org/jira/browse/INFRA-11294 -- I'll file one now

@shivaram
Copy link
Contributor

shivaram commented Sep 9, 2016

Created https://issues.apache.org/jira/browse/INFRA-12590

@HyukjinKwon
Copy link
Member

HyukjinKwon commented Sep 9, 2016

I will check this out as far as I can and be back.

@HyukjinKwon
Copy link
Member

HyukjinKwon commented Sep 9, 2016

@dongjoon-hyun Meanwhile, do you mind if I ask whether you have any idea on this maybe?

@dongjoon-hyun
Copy link
Member

dongjoon-hyun commented Sep 9, 2016

Up to my knowledge, INFRA ticket made by @shivaram is enough for now. For Apache REEF, we filed the following INFRA issue like that.

https://issues.apache.org/jira/browse/INFRA-11411

@SparkQA
Copy link

SparkQA commented Sep 9, 2016

Test build #65135 has finished for PR 15015 at commit 91ae8d6.

  • This patch passes all tests.
  • This patch merges cleanly.
  • This patch adds no public classes.

@felixcheung
Copy link
Member

felixcheung commented Sep 9, 2016

LGTM

@SparkQA
Copy link

SparkQA commented Sep 9, 2016

Test build #65173 has finished for PR 15015 at commit d526890.

  • This patch passes all tests.
  • This patch merges cleanly.
  • This patch adds no public classes.

@shivaram
Copy link
Contributor

shivaram commented Sep 10, 2016

Thanks @keypointt - Merging into master

@asfgit asfgit closed this in 71b7d42 Sep 10, 2016
wgtmac pushed a commit to wgtmac/spark that referenced this pull request Sep 19, 2016
@keypointt @wgtmac
[SPARK-16445][MLLIB][SPARKR] Fix @return description for sparkR mlp s…
9e6680e 
…ummary() method

## What changes were proposed in this pull request?

Fix summary() method's `return` description for spark.mlp

## How was this patch tested?

Ran tests locally on my laptop.

Author: Xin Ren <iamshrek@126.com>

Closes apache#15015 from keypointt/SPARK-16445-2.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

6 participants

@keypointt @SparkQA @felixcheung @HyukjinKwon @shivaram @dongjoon-hyun