-
Notifications
You must be signed in to change notification settings - Fork 29k
[SPARK-17473][SQL] fixing docker integration tests error due to different versions of jars. #15114
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[SPARK-17473][SQL] fixing docker integration tests error due to different versions of jars. #15114
Conversation
…h of jersey versions
|
Test build #65461 has finished for PR 15114 at commit
|
|
Let me give this a try locally and I'll report back whether it works for me. If so, I'll merge this. |
|
I thought Jackson 1.x and 2.x were in different namespaces so I don't think they should be able to collide? In any event, if it works, that's great, as it reduces the complexity here, but the root cause might be slightly different. |
|
I verified this works on native docker in linux with : LGTM. |
|
I tried running this in SBT and ran into a bunch of spurious exceptions from logging code: This didn't lead to test failures but made the test output a bit noisy while it was downloading images for the first time. This seems like it might be tricky to fix, though, so I'm going to merge this now to unblock developers who might rely on these tests. Thanks! |
…rent versions of jars. ## What changes were proposed in this pull request? Docker tests are using older version of jersey jars (1.19), which was used in older releases of spark. In 2.0 releases Spark was upgraded to use 2.x verison of Jersey. After upgrade to new versions, docker tests are failing with AbstractMethodError. Now that spark is upgraded to 2.x jersey version, using of shaded docker jars may not be required any more. Removed the exclusions/overrides of jersey related classes from pom file, and changed the docker-client to use regular jar instead of shaded one. ## How was this patch tested? Tested using existing docker-integration-tests Author: sureshthalamati <suresh.thalamati@gmail.com> Closes #15114 from sureshthalamati/docker_testfix-spark-17473. (cherry picked from commit cdea1d1) Signed-off-by: Josh Rosen <joshrosen@databricks.com>
…rent versions of jars. ## What changes were proposed in this pull request? Docker tests are using older version of jersey jars (1.19), which was used in older releases of spark. In 2.0 releases Spark was upgraded to use 2.x verison of Jersey. After upgrade to new versions, docker tests are failing with AbstractMethodError. Now that spark is upgraded to 2.x jersey version, using of shaded docker jars may not be required any more. Removed the exclusions/overrides of jersey related classes from pom file, and changed the docker-client to use regular jar instead of shaded one. ## How was this patch tested? Tested using existing docker-integration-tests Author: sureshthalamati <suresh.thalamati@gmail.com> Closes apache#15114 from sureshthalamati/docker_testfix-spark-17473.
What changes were proposed in this pull request?
Docker tests are using older version of jersey jars (1.19), which was used in older releases of spark. In 2.0 releases Spark was upgraded to use 2.x verison of Jersey. After upgrade to new versions, docker tests are failing with AbstractMethodError. Now that spark is upgraded to 2.x jersey version, using of shaded docker jars may not be required any more. Removed the exclusions/overrides of jersey related classes from pom file, and changed the docker-client to use regular jar instead of shaded one.
How was this patch tested?
Tested using existing docker-integration-tests