[SPARK-17561] [DOCS] DataFrameWriter documentation formatting problems #15117
+53
−29
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
|
Hi @srowen, I support this PR. It's a super minor but would this be sensible if we re-indent the child elements in the HTML in newly added parents? |
|
Test build #65482 has finished for PR 15117 at commit
|
|
Test build #65484 has finished for PR 15117 at commit
|
Contributor
|
LGTM - merging in master/2.0. |
Contributor
|
I merged this in master but there's a conflict with branch-2.0. Can you create a patch for 2.0? |
asfgit
pushed a commit
that referenced
this pull request
Sep 17, 2016
Fix `<ul> / <li>` problems in SQL scaladoc. Scaladoc build and manual verification of generated HTML. Author: Sean Owen <sowen@cloudera.com> Closes #15117 from srowen/SPARK-17561. (cherry picked from commit b9323fc) Signed-off-by: Sean Owen <sowen@cloudera.com>
Member
Author
|
Sure, I just merged it to 2.0 and resolved the conflict because that was straightforward here. |
wgtmac
pushed a commit
to wgtmac/spark
that referenced
this pull request
Sep 19, 2016
## What changes were proposed in this pull request? Fix `<ul> / <li>` problems in SQL scaladoc. ## How was this patch tested? Scaladoc build and manual verification of generated HTML. Author: Sean Owen <sowen@cloudera.com> Closes apache#15117 from srowen/SPARK-17561.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
Fix
<ul> / <li>problems in SQL scaladoc.How was this patch tested?
Scaladoc build and manual verification of generated HTML.