Skip to content

[SPARK-17595] [MLLib] Use a bounded priority queue to find synonyms in Word2VecModel #15150

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
willb wants to merge 4 commits into from
Closed

[SPARK-17595] [MLLib] Use a bounded priority queue to find synonyms in Word2VecModel #15150

Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
ddba657
Use a bounded priority queue to find synonyms in Word2VecModel
willb Sep 19, 2016
93ebb94
Stylistic cleanups from review
willb Sep 19, 2016
f7311a2
Removed redundant take from Word2VecModel.findSynonyms
willb Sep 20, 2016
4b235dc
Prefer explicit iteration over indices to zip; avoid allocating an ar…
willb Sep 20, 2016
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
13 changes: 10 additions & 3 deletions mllib/src/main/scala/org/apache/spark/mllib/feature/Word2Vec.scala
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -35,6 +35,7 @@ import org.apache.spark.mllib.linalg.{Vector, Vectors}
import org.apache.spark.mllib.util.{Loader, Saveable}
import org.apache.spark.rdd._
import org.apache.spark.sql.SparkSession
import org.apache.spark.util.BoundedPriorityQueue
import org.apache.spark.util.Utils
import org.apache.spark.util.random.XORShiftRandom

Expand Down Expand Up @@ -555,7 +556,7 @@ class Word2VecModel private[spark] (
num: Int,
wordOpt: Option[String]): Array[(String, Double)] = {
require(num > 0, "Number of similar words should > 0")
// TODO: optimize top-k

val fVector = vector.toArray.map(_.toFloat)
val cosineVec = Array.fill[Float](numWords)(0)
val alpha: Float = 1
Expand All @@ -580,10 +581,16 @@ class Word2VecModel private[spark] (
ind += 1
}

val scored = wordList.zip(cosVec).toSeq.sortBy(-_._2)
val pq = new BoundedPriorityQueue[(String, Double)](num + 1)(Ordering.by(_._2))

for(i <- cosVec.indices) {
pq += Tuple2(wordList(i), cosVec(i))
}

val scored = pq.toSeq.sortBy(-_._2)

val filtered = wordOpt match {
case Some(w) => scored.take(num + 1).filter(tup => w != tup._1)
case Some(w) => scored.filter(tup => w != tup._1)
case None => scored
}

Expand Down