[CORE][DOC]: Fix errors in comments #15151
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
srowen
requested changes
Sep 19, 2016
Member
srowen
left a comment
srowen
left a comment
There was a problem hiding this comment.
OK on the typo fix, but the rest isn't the kind of thing that's worth opening a PR for please
|
|
||
| /** | ||
| * Return true if Hive classes can be loaded, otherwise false. | ||
| * Returns true if Hive classes can be loaded, otherwise false. |
Member
There was a problem hiding this comment.
If you're going to change this, use @return
| * | ||
| * WARNING: Since there is no guaranteed ordering for fields in a Java Bean, | ||
| * SELECT * queries will return the columns in an undefined order. | ||
| * |
Member
There was a problem hiding this comment.
These two whitespace changes aren't worth making IMHO
|
Test build #65606 has finished for PR 15151 at commit
|
|
Test build #65672 has finished for PR 15151 at commit
|
Member
|
OK, merged to master. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
While reading source code of CORE and SQL core, I found some minor errors in comments such as extra space, missing blank line and grammar error.
I fixed these minor errors and might find more during my source code study.
How was this patch tested?
Manually build