[SPARK-15698][SQL][STREAMING] Add the ability to remove the old MetadataLog in FileStreamSource (branch-2.0) #15163
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ataLog in FileStreamSource Current `metadataLog` in `FileStreamSource` will add a checkpoint file in each batch but do not have the ability to remove/compact, which will lead to large number of small files when running for a long time. So here propose to compact the old logs into one file. This method is quite similar to `FileStreamSinkLog` but simpler. Unit test added. Author: jerryshao <sshao@hortonworks.com> Closes #13513 from jerryshao/SPARK-15698. (cherry picked from commit a6aade0) Signed-off-by: Shixiong Zhu <shixiong@databricks.com>
zsxwing
commented
Sep 20, 2016
| * old files while another one keeps retrying. Setting a reasonable cleanup delay could avoid it. | ||
| */ | ||
| private val fileCleanupDelayMs = sparkSession.conf.get(SQLConf.FILE_SINK_LOG_CLEANUP_DELAY) | ||
| protected override val fileCleanupDelayMs = |
Member
Author
There was a problem hiding this comment.
Just resolved conflicts for these 3 confs
|
Test build #65673 has finished for PR 15163 at commit
|
Member
Author
|
Merging to 2.0 since tests passed. |
asfgit
pushed a commit
that referenced
this pull request
Sep 20, 2016
…ataLog in FileStreamSource (branch-2.0) ## What changes were proposed in this pull request? Backport #13513 to branch 2.0. ## How was this patch tested? Jenkins Author: jerryshao <sshao@hortonworks.com> Closes #15163 from zsxwing/SPARK-15698-spark-2.0.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
Backport #13513 to branch 2.0.
How was this patch tested?
Jenkins