[SPARK-17613] S3A base paths with no '/' at the end return empty DataFrames #15169
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
Author
|
cc @tdas This is the fix for the issue you were facing. |
|
Test build #65688 has finished for PR 15169 at commit
|
|
Test build #65683 has finished for PR 15169 at commit
|
|
Test build #65689 has finished for PR 15169 at commit
|
|
Test build #65731 has finished for PR 15169 at commit
|
Contributor
|
LGTM. I walked through the code in IntelliJ and have verified that the added unit test fails without this change. It's weird that |
asfgit
pushed a commit
that referenced
this pull request
Sep 22, 2016
…Frames Consider you have a bucket as `s3a://some-bucket` and under it you have files: ``` s3a://some-bucket/file1.parquet s3a://some-bucket/file2.parquet ``` Getting the parent path of `s3a://some-bucket/file1.parquet` yields `s3a://some-bucket/` and the ListingFileCatalog uses this as the key in the hash map. When catalog.allFiles is called, we use `s3a://some-bucket` (no slash at the end) to get the list of files, and we're left with an empty list! This PR fixes this by adding a `/` at the end of the `URI` iff the given `Path` doesn't have a parent, i.e. is the root. This is a no-op if the path already had a `/` at the end, and is handled through the Hadoop Path, path merging semantics. Unit test in `FileCatalogSuite`. Author: Burak Yavuz <brkyvz@gmail.com> Closes #15169 from brkyvz/SPARK-17613. (cherry picked from commit 85d609c) Signed-off-by: Josh Rosen <joshrosen@databricks.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
Consider you have a bucket as
s3a://some-bucketand under it you have files:
Getting the parent path of
s3a://some-bucket/file1.parquetyieldss3a://some-bucket/and the ListingFileCatalog uses this as the key in the hash map.When catalog.allFiles is called, we use
s3a://some-bucket(no slash at the end) to get the list of files, and we're left with an empty list!This PR fixes this by adding a
/at the end of theURIiff the givenPathdoesn't have a parent, i.e. is the root. This is a no-op if the path already had a/at the end, and is handled through the Hadoop Path, path merging semantics.How was this patch tested?
Unit test in
FileCatalogSuite.