[SPARK-11918] [ML] Better error from WLS for cases like singular input #15177
Conversation
…more info when input is singular
| UAi | ||
| } | ||
|
|
||
| private def checkReturnValue(info: intW, method: String): Unit = { |
There was a problem hiding this comment.
CC @yanboliang -- tried to add more to the error messages here, and distinguish between unsupported input (illegal argument) and bad call to LAPACK (illegal state? an assertion error seemed like too much)
| private def checkReturnValue(info: intW, method: String): Unit = { | ||
| info.`val` match { | ||
| case code if code < 0 => | ||
| throw new IllegalStateException(s"LAPACK.$method returned $code; arg ${-code} is illegal") |
There was a problem hiding this comment.
Should we output arg ${-code}? Since the arguments is internal used and MLlib users have no sense of them and can do nothing to verify it. If the arguments of dppsv is illegal, it should be caused by bugs of MLlib.
There was a problem hiding this comment.
Yes, none of this info is really useful to the end user in this case because it's a bug. It may be useful in an error report. I figured it's worth saying something and why not say a little more about the cause to help anyone who cares save the step of looking up what "-2" means.
|
Test build #65710 has finished for PR 15177 at commit
|
|
LGTM |
|
LGTM. Merged into master. Thanks. |
4 participants
What changes were proposed in this pull request?
Update error handling for Cholesky decomposition to provide a little more info when input is singular.
How was this patch tested?
New test case; jenkins tests.