[SPARK-17625] [SQL] set expectedOutputAttributes when converting SimpleCatalogRelation to LogicalRelation

[wzhfy]

What changes were proposed in this pull request?

When converting SimpleCatalogRelation to LogicalRelation, we also need to set expectedOutputAttributes, then the output in LogicalRelation is the attributes in expectedOutputAttributes, otherwise, it will use its schema to generate new attributes (and new exprId's), so the output of LogicalRelation will be different from output of SimpleCatalogRelation.

As a result, if we have a table in InMemoryCatalog, we can't lookup it (get a SimpleCatalogRelation) and then use it to compose LogicalPlans.

How was this patch tested?

add a test case

[wzhfy]

@cloud-fan @gatorsmile

[wzhfy]

Maybe the position of the test case is not right, where should I put it?

[SparkQA]

Test build #65725 has finished for PR 15182 at commit 3e7beb8.

• This patch passes all tests.
• This patch merges cleanly.
• This patch adds no public classes.

[gatorsmile]

Your test case can be simplified to

    val tableName = "tbl"
    withTable(tableName) {
      spark.range(10).select('id as 'i, 'id as 'j).write.saveAsTable(tableName)
      val relation = spark.sessionState.catalog.lookupRelation(TableIdentifier(tableName))
      val expr = relation.resolve("i")
      Dataset.ofRows(spark, Project(Seq(expr), relation))
    }

[gatorsmile]

The fix looks ok to me, but you need to improve your PR description. It might not be easy for reviewers to understand your fix based on your PR description.

I do not know which test suite is the best place, but SQLQuerySuite is not good for sure. Your test case is not related to SQL. Let @cloud-fan make the decision. : )

[cloud-fan]

Let's put it in DataFrameSuite

[wzhfy]

@cloud-fan Ok.

[gatorsmile]

LGTM pending Jenkins

[cloud-fan]

LGTM

[SparkQA]

Test build #65756 has finished for PR 15182 at commit e2c3b9d.

• This patch passes all tests.
• This patch merges cleanly.
• This patch adds no public classes.

[cloud-fan]

thanks, merging to master!