Revert "[SPARK-17704][ML][MLLIB] ChiSqSelector performance improvement." #15298
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This reverts commit f7082ac.
Member
|
Yes that's fine, note you can also just revert the PR and push that commit straight to the apache git remote if you want to. |
Contributor
Author
|
@srowen Sure. Thanks. |
Member
|
OK instead of reverting this, maybe it's easier to just consider an additional change. What do you think of #15299? |
Contributor
Author
|
OK, I'll close this one and move to #15299 . Thanks. |
|
Test build #66098 has finished for PR 15298 at commit
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
Revert "[SPARK-17704][ML][MLLIB] ChiSqSelector performance improvement."
This reverts commit f7082ac.
How was this patch tested?