Skip to content

[SPARK-17940][SQL] Fixed a typo in LAST function and improved its usage string #15487

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
lins05 wants to merge 3 commits into from
Closed

[SPARK-17940][SQL] Fixed a typo in LAST function and improved its usage string #15487

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
33988d3
[SPARK-17940][SQL] Fixed a typo in LAST function and improved its usa…
lins05 Oct 14, 2016
fcf8bb5
Added the note about nondeterministic.
lins05 Oct 16, 2016
4c3f043
Improve usage string format.
lins05 Oct 18, 2016
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 7 additions & 2 deletions sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/aggregate/First.scala
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -29,9 +29,14 @@ import org.apache.spark.sql.types._
* a single partition, and we use a single reducer to do the aggregation.).
*/
@ExpressionDescription(
usage = """_FUNC_(expr) - Returns the first value of `child` for a group of rows.
_FUNC_(expr,isIgnoreNull=false) - Returns the first value of `child` for a group of rows.
usage =
"""
_FUNC_(expr) - Returns the first value of `child` for a group of rows.

_FUNC_(expr, isIgnoreNull=false) - Returns the first value of `child` for a group of rows.
If isIgnoreNull is true, returns only non-null values.

Note that in most cases the result is nondeterministic.
""")
case class First(child: Expression, ignoreNullsExpr: Expression) extends DeclarativeAggregate {

Expand Down
12 changes: 10 additions & 2 deletions sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/aggregate/Last.scala
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -29,15 +29,23 @@ import org.apache.spark.sql.types._
* a single partition, and we use a single reducer to do the aggregation.).
*/
@ExpressionDescription(
usage = "_FUNC_(expr,isIgnoreNull) - Returns the last value of `child` for a group of rows.")
usage =
"""
_FUNC_(expr) - Returns the last value of `child` for a group of rows.

_FUNC_(expr, isIgnoreNull) - Returns the last value of `child` for a group of rows.
If isIgnoreNull is true, returns only non-null values.

Note that in most cases the result is nondeterministic.
""")
case class Last(child: Expression, ignoreNullsExpr: Expression) extends DeclarativeAggregate {

def this(child: Expression) = this(child, Literal.create(false, BooleanType))

private val ignoreNulls: Boolean = ignoreNullsExpr match {
case Literal(b: Boolean, BooleanType) => b
case _ =>
throw new AnalysisException("The second argument of First should be a boolean literal.")
throw new AnalysisException("The second argument of Last should be a boolean literal.")
}

override def children: Seq[Expression] = child :: ignoreNullsExpr :: Nil
Expand Down