[SPARK-17731][SQL][STREAMING][FOLLOWUP] Refactored StreamingQueryListener APIs #15530
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Test build #67117 has finished for PR 15530 at commit
|
Contributor
Author
|
Test build #67119 has finished for PR 15530 at commit
|
rxin
reviewed
Oct 18, 2016
| * @since 2.0.0 | ||
| */ | ||
| def onQueryProgress(queryProgress: QueryProgress): Unit | ||
| def onQueryProgress(queryProgress: QueryProgressEvent): Unit |
Contributor
There was a problem hiding this comment.
sry i was referring to just renaming all the arguments to event... but now i look at it QueryProgressEvent also sound good!
Contributor
Author
|
@rxin Can you take a look once again. |
Contributor
|
LGTM |
|
Test build #67139 has finished for PR 15530 at commit
|
asfgit
pushed a commit
that referenced
this pull request
Oct 19, 2016
…ener APIs for branch-2.0 This is the branch-2.0 PR of #15530 to make the APIs consistent with the master. Since these APIs are experimental and not direct user facing (StreamingQueryListener is advanced Structured Streaming APIs), its okay to change them in branch-2.0. ## What changes were proposed in this pull request? As per rxin request, here are further API changes - Changed `Stream(Started/Progress/Terminated)` events to `Stream*Event` - Changed the fields in `StreamingQueryListener.on***` from `query*` to `event` ## How was this patch tested? Existing unit tests. Author: Tathagata Das <tathagata.das1565@gmail.com> Closes #15535 from tdas/SPARK-17731-1-branch-2.0.
Contributor
Author
|
I am merging this. |
|
Test build #67145 has finished for PR 15530 at commit
|
robert3005
pushed a commit
to palantir/spark
that referenced
this pull request
Nov 1, 2016
…ener APIs ## What changes were proposed in this pull request? As per rxin request, here are further API changes - Changed `Stream(Started/Progress/Terminated)` events to `Stream*Event` - Changed the fields in `StreamingQueryListener.on***` from `query*` to `event` ## How was this patch tested? Existing unit tests. Author: Tathagata Das <tathagata.das1565@gmail.com> Closes apache#15530 from tdas/SPARK-17731-1.
uzadude
pushed a commit
to uzadude/spark
that referenced
this pull request
Jan 27, 2017
…ener APIs ## What changes were proposed in this pull request? As per rxin request, here are further API changes - Changed `Stream(Started/Progress/Terminated)` events to `Stream*Event` - Changed the fields in `StreamingQueryListener.on***` from `query*` to `event` ## How was this patch tested? Existing unit tests. Author: Tathagata Das <tathagata.das1565@gmail.com> Closes apache#15530 from tdas/SPARK-17731-1.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
As per @rxin request, here are further API changes
Stream(Started/Progress/Terminated)events toStream*EventStreamingQueryListener.on***fromquery*toeventHow was this patch tested?
Existing unit tests.