Skip to content

Conversation

@felixcheung
Copy link
Member

@felixcheung felixcheung commented Oct 21, 2016

What changes were proposed in this pull request?

testthat library we are using for testing R is redirecting warning (and disabling options("warn" = 2)), we need to have a way to detect any new warning and fail

How was this patch tested?

manual testing, Jenkins

@SparkQA
Copy link

SparkQA commented Oct 21, 2016

Test build #67308 has finished for PR 15576 at commit 5185a37.

  • This patch fails SparkR unit tests.
  • This patch merges cleanly.
  • This patch adds no public classes.

@felixcheung
Copy link
Member Author

Test failure is intentional, it's picking up the following warnings:

Warnings -----------------------------------------------------------------------
1. createDataFrame uses files for large objects (@test_sparkSQL.R#215) - Use Sepal_Length instead of Sepal.Length  as column name

2. createDataFrame uses files for large objects (@test_sparkSQL.R#215) - Use Sepal_Width instead of Sepal.Width  as column name

3. createDataFrame uses files for large objects (@test_sparkSQL.R#215) - Use Petal_Length instead of Petal.Length  as column name

4. createDataFrame uses files for large objects (@test_sparkSQL.R#215) - Use Petal_Width instead of Petal.Width  as column name

Which is fixed in PR #15560

@felixcheung felixcheung changed the title [WIP][SPARK-17674][SPARKR] check for warning in test output [SPARK-17674][SPARKR] check for warning in test output Oct 21, 2016
@felixcheung
Copy link
Member Author

Rebased. This should pass now.

@SparkQA
Copy link

SparkQA commented Oct 21, 2016

Test build #67321 has finished for PR 15576 at commit 1c9bd2e.

  • This patch passes all tests.
  • This patch merges cleanly.
  • This patch adds no public classes.

@wangmiao1981
Copy link
Contributor

Thanks for fixing this! I encountered this issue before.

@asfgit asfgit closed this in 4efdc76 Oct 21, 2016
@felixcheung
Copy link
Member Author

merged to master, thanks

robert3005 pushed a commit to palantir/spark that referenced this pull request Nov 1, 2016
## What changes were proposed in this pull request?

testthat library we are using for testing R is redirecting warning (and disabling `options("warn" = 2)`), we need to have a way to detect any new warning and fail

## How was this patch tested?

manual testing, Jenkins

Author: Felix Cheung <felixcheung_m@hotmail.com>

Closes apache#15576 from felixcheung/rtestwarning.
uzadude pushed a commit to uzadude/spark that referenced this pull request Jan 27, 2017
## What changes were proposed in this pull request?

testthat library we are using for testing R is redirecting warning (and disabling `options("warn" = 2)`), we need to have a way to detect any new warning and fail

## How was this patch tested?

manual testing, Jenkins

Author: Felix Cheung <felixcheung_m@hotmail.com>

Closes apache#15576 from felixcheung/rtestwarning.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants