Skip to content

Conversation

@felixcheung
Copy link
Member

What changes were proposed in this pull request?

Random Forest Regression and Classification for R
Clean-up/reordering generics.R

How was this patch tested?

manual tests, unit tests

@SparkQA
Copy link

SparkQA commented Oct 24, 2016

Test build #67438 has finished for PR 15607 at commit 7d6e605.

  • This patch fails some tests.
  • This patch merges cleanly.
  • This patch adds the following public classes (experimental):
    • class RandomForestClassifierWrapperWriter(instance: RandomForestClassifierWrapper)
    • class RandomForestClassifierWrapperReader extends MLReader[RandomForestClassifierWrapper]
    • class RandomForestRegressorWrapperWriter(instance: RandomForestRegressorWrapper)
    • class RandomForestRegressorWrapperReader extends MLReader[RandomForestRegressorWrapper]

@SparkQA
Copy link

SparkQA commented Oct 24, 2016

Test build #67441 has finished for PR 15607 at commit 4442abe.

  • This patch fails some tests.
  • This patch merges cleanly.
  • This patch adds no public classes.

@felixcheung
Copy link
Member Author

Hmm, it works fine with
roxygen2 "roxygen2" "/usr/local/lib/R/site-library" "5.0.1"

maybe it is the older version on Jenkins?

First time using roxygen2 4.0. Upgrading automatically...
Error: Failure in roxygen block beginning mllib.R:1449
Mismatched braces: "@param featureSubsetStrategy The number of features to consider for splits at each tree node.
       See
\href{http://spark.apache.org/docs/latest/api/scala/index.html#org.apache.spark.ml.classification.RandomForestClassifier"
Execution halted

@SparkQA
Copy link

SparkQA commented Oct 24, 2016

Test build #67442 has finished for PR 15607 at commit b44dada.

  • This patch fails Scala style tests.
  • This patch merges cleanly.
  • This patch adds no public classes.

@SparkQA
Copy link

SparkQA commented Oct 24, 2016

Test build #67443 has finished for PR 15607 at commit 0b9fa4f.

  • This patch passes all tests.
  • This patch merges cleanly.
  • This patch adds no public classes.

@SparkQA
Copy link

SparkQA commented Oct 24, 2016

Test build #67476 has finished for PR 15607 at commit 19ad285.

  • This patch passes all tests.
  • This patch merges cleanly.
  • This patch adds no public classes.

@felixcheung
Copy link
Member Author

@yanboliang @mengxr would love your review. thanks.

@SparkQA
Copy link

SparkQA commented Oct 27, 2016

Test build #67628 has finished for PR 15607 at commit a4081d4.

  • This patch fails some tests.
  • This patch merges cleanly.
  • This patch adds no public classes.

@SparkQA
Copy link

SparkQA commented Oct 27, 2016

Test build #67629 has finished for PR 15607 at commit 96ce6a5.

  • This patch passes all tests.
  • This patch merges cleanly.
  • This patch adds no public classes.

@felixcheung
Copy link
Member Author

merged to master.

@asfgit asfgit closed this in b6879b8 Oct 30, 2016
robert3005 pushed a commit to palantir/spark that referenced this pull request Nov 1, 2016
## What changes were proposed in this pull request?

Random Forest Regression and Classification for R
Clean-up/reordering generics.R

## How was this patch tested?

manual tests, unit tests

Author: Felix Cheung <felixcheung_m@hotmail.com>

Closes apache#15607 from felixcheung/rrandomforest.
uzadude pushed a commit to uzadude/spark that referenced this pull request Jan 27, 2017
## What changes were proposed in this pull request?

Random Forest Regression and Classification for R
Clean-up/reordering generics.R

## How was this patch tested?

manual tests, unit tests

Author: Felix Cheung <felixcheung_m@hotmail.com>

Closes apache#15607 from felixcheung/rrandomforest.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants