[SPARK-18103] [SQL] Rename *FileCatalog to *FileIndex #15634
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Test build #67544 has finished for PR 15634 at commit
|
Contributor
|
This is okay, but note that "Provider" is equally overloaded in the Data Source API. |
Contributor
Author
|
Hmm, any other suggestions? |
Contributor
|
FileLister? FileListing? |
Contributor
Author
|
How about |
Contributor
Author
|
Concretely, I propose renaming I think this would make the differences between these classes more clear. Previously, the name was only loosely tied with their behavior. |
Contributor
|
FileIndex sounds good to me. I wouldn't call it "Metastore" though, since that is a Hive specific term. I'd call it Catalog. |
ericl
force-pushed
the
rename-file-provider
branch
from
0776537 to
b6654f1
Compare
|
Test build #67717 has finished for PR 15634 at commit
|
ericl
changed the title
|
Test build #67718 has finished for PR 15634 at commit
|
Contributor
|
LGTM pending tests. |
|
Test build #67747 has finished for PR 15634 at commit
|
Contributor
|
Merging in master. |
robert3005
pushed a commit
to palantir/spark
that referenced
this pull request
Nov 1, 2016
## What changes were proposed in this pull request? To reduce the number of components in SQL named *Catalog, rename *FileCatalog to *FileIndex. A FileIndex is responsible for returning the list of partitions / files to scan given a filtering expression. ``` TableFileCatalog => CatalogFileIndex FileCatalog => FileIndex ListingFileCatalog => InMemoryFileIndex MetadataLogFileCatalog => MetadataLogFileIndex PrunedTableFileCatalog => PrunedInMemoryFileIndex ``` cc yhuai marmbrus ## How was this patch tested? N/A Author: Eric Liang <ekl@databricks.com> Author: Eric Liang <ekhliang@gmail.com> Closes apache#15634 from ericl/rename-file-provider.
ghost
pushed a commit
to dbtsai/spark
that referenced
this pull request
Nov 1, 2016
…to `MetadataLogFileIndex` ## What changes were proposed in this pull request? This is a follow-up to apache#15634. ## How was this patch tested? N/A Author: Liwei Lin <lwlin7@gmail.com> Closes apache#15712 from lw-lin/18103.
uzadude
pushed a commit
to uzadude/spark
that referenced
this pull request
Jan 27, 2017
## What changes were proposed in this pull request? To reduce the number of components in SQL named *Catalog, rename *FileCatalog to *FileIndex. A FileIndex is responsible for returning the list of partitions / files to scan given a filtering expression. ``` TableFileCatalog => CatalogFileIndex FileCatalog => FileIndex ListingFileCatalog => InMemoryFileIndex MetadataLogFileCatalog => MetadataLogFileIndex PrunedTableFileCatalog => PrunedInMemoryFileIndex ``` cc yhuai marmbrus ## How was this patch tested? N/A Author: Eric Liang <ekl@databricks.com> Author: Eric Liang <ekhliang@gmail.com> Closes apache#15634 from ericl/rename-file-provider.
uzadude
pushed a commit
to uzadude/spark
that referenced
this pull request
Jan 27, 2017
…to `MetadataLogFileIndex` ## What changes were proposed in this pull request? This is a follow-up to apache#15634. ## How was this patch tested? N/A Author: Liwei Lin <lwlin7@gmail.com> Closes apache#15712 from lw-lin/18103.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
To reduce the number of components in SQL named *Catalog, rename *FileCatalog to *FileIndex. A FileIndex is responsible for returning the list of partitions / files to scan given a filtering expression.
cc @yhuai @marmbrus
How was this patch tested?
N/A