[SPARK-18110][PYTHON][ML] add missing parameter in Python for RandomForest regression and classification #15638
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
felixcheung
changed the title
| class RandomForestRegressor(JavaEstimator, HasFeaturesCol, HasLabelCol, HasPredictionCol, HasSeed, | ||
| RandomForestParams, TreeRegressorParams, HasCheckpointInterval, | ||
| JavaMLWritable, JavaMLReadable): | ||
| JavaMLWritable, JavaMLReadable, HasVarianceCol): |
Contributor
There was a problem hiding this comment.
Would you like to group all the Has* parameters? Just a minor comment on the style.
Member
Author
There was a problem hiding this comment.
that doesn't seem to be the existing style, so adding to the end instead
| maxDepth=5, maxBins=32, minInstancesPerNode=1, minInfoGain=0.0, | ||
| maxMemoryInMB=256, cacheNodeIds=False, checkpointInterval=10, impurity="gini", | ||
| numTrees=20, featureSubsetStrategy="auto", seed=None): | ||
| numTrees=20, featureSubsetStrategy="auto", seed=None, subsamplingRate=1.0): |
Contributor
There was a problem hiding this comment.
Add some doc string tests?
Member
Author
There was a problem hiding this comment.
generally spark avoid having too many verbose tests in python doc string, so I think we are ok here.
|
Test build #67558 has finished for PR 15638 at commit
|
Member
Author
|
merged to master. |
robert3005
pushed a commit
to palantir/spark
that referenced
this pull request
Nov 1, 2016
…orest regression and classification ## What changes were proposed in this pull request? Add subsmaplingRate to randomForestClassifier Add varianceCol to randomForestRegressor In Python ## How was this patch tested? manual tests Author: Felix Cheung <felixcheung_m@hotmail.com> Closes apache#15638 from felixcheung/pyrandomforest.
uzadude
pushed a commit
to uzadude/spark
that referenced
this pull request
Jan 27, 2017
…orest regression and classification ## What changes were proposed in this pull request? Add subsmaplingRate to randomForestClassifier Add varianceCol to randomForestRegressor In Python ## How was this patch tested? manual tests Author: Felix Cheung <felixcheung_m@hotmail.com> Closes apache#15638 from felixcheung/pyrandomforest.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
Add subsmaplingRate to randomForestClassifier
Add varianceCol to randomForestRegressor
In Python
How was this patch tested?
manual tests