-
Notifications
You must be signed in to change notification settings - Fork 29k
[MINOR][DOC] Remove spaces following slashs #15686
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
Test build #67782 has finished for PR 15686 at commit
|
|
Thank you for review and approval, @srowen ! |
|
Build started: [SparkR] :) |
|
@HyukjinKwon why are the appveyor checks failing? |
|
@rxin, it seems spurious. The message seems meaning the failure when the commit is virtually not mergeable[1]. It seems it fails time to time for various reasons. For example, in some cases, it seems failing to clone due to network problem within AppVeyor[2]. it is able to re-trigger via Web UI but it seems committers are also not allowed to access to it. Due to this problem, I temporarily made a bunch of scripts[3] to manually launch another build via @spark-test account. I can run the build and leave the comment above until we find a better way to handle it. (treat me like a bot) [1]http://help.appveyor.com/discussions/problems/4912-merge-commit-does-not-start-build-in-the-repo-i-make-pull-request-for |
|
I believe the message indicates the same case with the PR 15673 and 15689 but it seems spurious in this case. |
|
This change seems fine. If Appveyor is encountering errors regularly, we might consider disabling it, just because it wouldn't be giving useful information if most failures were spurious. |
|
There are three problems with it.
I am neutral because it seems the cases are not often. I may open a JIRA if I incline toward disabling this or please feel free to create a JIRA if anyone feels so. (Let me please cc @shivaram. I would like him to know about this). |
|
Yeah I think it'll be a good idea to know the error rate we hit. @HyukjinKwon It might also be good to create an INFRA ticket to see if we can re-trigger the AppVeyor builds somehow ? |
|
@dongjoon-hyun I am sorry for unrelated comments here. All these comments are not related with this PR. @shivaram Sure, Let me try to create a JIRA. I will cc you. We might be able to talk more there. |
|
Never mind, @hyunjinkwon . |
|
Merged to master |
|
Thank you for merging, @srowen . |
## What changes were proposed in this pull request? This PR merges multiple lines enumerating items in order to remove the redundant spaces following slashes in [Structured Streaming Programming Guide in 2.0.2-rc1](http://people.apache.org/~pwendell/spark-releases/spark-2.0.2-rc1-docs/structured-streaming-programming-guide.html). - Before: `Scala/ Java/ Python` - After: `Scala/Java/Python` ## How was this patch tested? Manual by the followings because this is documentation update. ``` cd docs SKIP_API=1 jekyll build ``` Author: Dongjoon Hyun <dongjoon@apache.org> Closes apache#15686 from dongjoon-hyun/minor_doc_space.
What changes were proposed in this pull request?
This PR merges multiple lines enumerating items in order to remove the redundant spaces following slashes in Structured Streaming Programming Guide in 2.0.2-rc1.
Scala/ Java/ PythonScala/Java/PythonHow was this patch tested?
Manual by the followings because this is documentation update.