-
Notifications
You must be signed in to change notification settings - Fork 29k
[SparkR][Test]:remove unnecessary suppressWarnings #15697
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
Test build #67827 has finished for PR 15697 at commit
|
|
retest it please |
|
windows failure seems unrelated |
|
Build started: [SparkR] |
|
Hm, yes it seems unrelated. I will look into this deeper. |
|
It seems R 3.3.2 is released but not for Windows yet (in see - https://cloud.r-project.org/bin/windows/base/old). So, it retrieves the latest version as 3.3.2. So it tries to download the older version 3.3.1 which does not exist. I guess this should be fine soon but if it is not going to release 3.3.2 for Windows, I will make the R version down to 3.3.0 for AppVeyor. |
|
@HyukjinKwon Thanks for your time! |
|
Build started: [SparkR] I am pretty sure it is fine now :) it seems 3.3.2 was just released. |
|
retest this please |
|
Test build #67909 has finished for PR 15697 at commit
|
|
retest this please |
|
Test build #67920 has finished for PR 15697 at commit
|
|
@HyukjinKwon It seems that windows test still fails with the same error |
|
Oh, AppVeyor test is not triggered again with the Jebkins one. |
|
No, I just launched Jenkins test. I don't know how to manually trigger the AppVeyor test. |
|
Ah, yes actually that's a problem now unfortunately. It seems even comitters can't retrigger. Actually, that's why I ran this via another account and left the comment above. I am trying to find a better way and will probably open a INFRA jira. |
|
Hey @wangmiao1981, I just found another (a bit ugly) workaround to re-trigger. It seems it starts to rebuild after closing and re-opening. I just tested in spark-test#11. If you are worried of the failure mark, maybe you could try. |
|
@HyukjinKwon the time window when download of an older version of R for windows could fail seem concerning. Is there a way to address that? |
|
For the specific failure here, it was due to not syncing the latest version between the releases for Winodws and the others (when R 3.3.2 was released). As we use a fixed version, R 3.3.1 now (not the latest but old one), we wouldn't meet the same case for the same reason in the future (I described this problem in more details in #15709). However, I guess you meant the concern of re-triggering the spurious failures in general. For re-triggering tests, I am still looking into this deeper. Will make a INFRA JIRA as soon as I figure out the way committers can re-trigger. Current ways I have figured out so far as a (ugly) workaround are,
|
|
Now, I try to close and reopen it to trigger another windows test. |
|
reopen it now. |
|
right, I think I see two problems, both of those you have looked into (thanks) second, re-triggering is spotty. Is that perhaps an appveyor issue? In any case we could likely follow up in separate JIRAs. |
|
Yes, it is probably an issue because it seems currently no one except who has the AppVeyor account called ApacheSoftwareFoundation can re-trigger. I should look into this further though.. Will update you. |
|
@felixcheung Any comments? |
|
merged to master. |
## What changes were proposed in this pull request? In test_mllib.R, there are two unnecessary suppressWarnings. This PR just removes them. ## How was this patch tested? Existing unit tests. Author: wm624@hotmail.com <wm624@hotmail.com> Closes apache#15697 from wangmiao1981/rtest.
What changes were proposed in this pull request?
In test_mllib.R, there are two unnecessary suppressWarnings. This PR just removes them.
How was this patch tested?
Existing unit tests.