[SPARK-18024][SQL] Introduce an internal commit protocol API #15707
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
[SPARK-18087] [SQL] Optimize insert to not require REPAIR TABLE
Contributor
Author
Contributor
|
This lgtm, modulo the comments in #15696 |
ericl
reviewed
Nov 1, 2016
| committer, | ||
| iterator = iter) | ||
| }).flatten.distinct | ||
| }) |
Contributor
There was a problem hiding this comment.
Move the distinct to updatedPartitions?
rxin
changed the title
|
Test build #67855 has finished for PR 15707 at commit
|
ericl
reviewed
Nov 1, 2016
|
|
||
| val STREAMING_FILE_COMMIT_PROTOCOL_CLASS = | ||
| SQLConfigBuilder("spark.sql.streaming.commitProtocolClass") | ||
| .internal() |
Contributor
|
This LGTM, just a minor comment |
|
Test build #67865 has finished for PR 15707 at commit
|
Contributor
Author
|
Looks like the test failed due to a flaky test, but other than that everything else was fine. I'm going to merge this optimistically. |
|
Test build #3384 has finished for PR 15707 at commit
|
|
Test build #3386 has finished for PR 15707 at commit
|
uzadude
pushed a commit
to uzadude/spark
that referenced
this pull request
Jan 27, 2017
## What changes were proposed in this pull request? This patch introduces an internal commit protocol API that is used by the batch data source to do write commits. It currently has only one implementation that uses Hadoop MapReduce's OutputCommitter API. In the future, this commit API can be used to unify streaming and batch commits. ## How was this patch tested? Should be covered by existing write tests. Author: Reynold Xin <rxin@databricks.com> Author: Eric Liang <ekl@databricks.com> Closes apache#15707 from rxin/SPARK-18024-2.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
This patch introduces an internal commit protocol API that is used by the batch data source to do write commits. It currently has only one implementation that uses Hadoop MapReduce's OutputCommitter API. In the future, this commit API can be used to unify streaming and batch commits.
How was this patch tested?
Should be covered by existing write tests.