[SPARK-18342] Make rename failures fatal in HDFSBackedStateStore #15804
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
Author
|
cc @tdas |
|
Test build #68317 has finished for PR 15804 at commit
|
brkyvz
commented
Nov 8, 2016
| val deltaFiles = allFiles.filter { file => | ||
| file.version > snapshotFile.version && file.version <= version | ||
| } | ||
| }.toList |
Contributor
Author
There was a problem hiding this comment.
the line returns a Stream which is a Scala Iterator like class, therefore the logging below doesn't work
|
Test build #68346 has finished for PR 15804 at commit
|
tdas
reviewed
Nov 8, 2016
|
|
||
| /** Fake FileSystem to test whether the method `fs.exists` is called during | ||
| * `DataSource.resolveRelation`. | ||
| */ |
tdas
reviewed
Nov 8, 2016
| } | ||
| } | ||
|
|
||
| test("commit fails when rename fails") { |
Contributor
There was a problem hiding this comment.
can you add the jira number here.
Contributor
|
looks good. to minor comments. |
Contributor
Author
|
@tdas Addressed |
|
Test build #68356 has finished for PR 15804 at commit
|
Contributor
|
LGTM. |
|
Test build #68358 has finished for PR 15804 at commit
|
Contributor
|
Merge this to master, 2.1 and 2.0 |
asfgit
pushed a commit
that referenced
this pull request
Nov 8, 2016
## What changes were proposed in this pull request? If the rename operation in the state store fails (`fs.rename` returns `false`), the StateStore should throw an exception and have the task retry. Currently if renames fail, nothing happens during execution immediately. However, you will observe that snapshot operations will fail, and then any attempt at recovery (executor failure / checkpoint recovery) also fails. ## How was this patch tested? Unit test Author: Burak Yavuz <brkyvz@gmail.com> Closes #15804 from brkyvz/rename-state. (cherry picked from commit 6f7ecb0) Signed-off-by: Tathagata Das <tathagata.das1565@gmail.com>
asfgit
pushed a commit
that referenced
this pull request
Nov 8, 2016
## What changes were proposed in this pull request? If the rename operation in the state store fails (`fs.rename` returns `false`), the StateStore should throw an exception and have the task retry. Currently if renames fail, nothing happens during execution immediately. However, you will observe that snapshot operations will fail, and then any attempt at recovery (executor failure / checkpoint recovery) also fails. ## How was this patch tested? Unit test Author: Burak Yavuz <brkyvz@gmail.com> Closes #15804 from brkyvz/rename-state. (cherry picked from commit 6f7ecb0) Signed-off-by: Tathagata Das <tathagata.das1565@gmail.com>
uzadude
pushed a commit
to uzadude/spark
that referenced
this pull request
Jan 27, 2017
## What changes were proposed in this pull request? If the rename operation in the state store fails (`fs.rename` returns `false`), the StateStore should throw an exception and have the task retry. Currently if renames fail, nothing happens during execution immediately. However, you will observe that snapshot operations will fail, and then any attempt at recovery (executor failure / checkpoint recovery) also fails. ## How was this patch tested? Unit test Author: Burak Yavuz <brkyvz@gmail.com> Closes apache#15804 from brkyvz/rename-state.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
If the rename operation in the state store fails (
fs.renamereturnsfalse), the StateStore should throw an exception and have the task retry. Currently if renames fail, nothing happens during execution immediately. However, you will observe that snapshot operations will fail, and then any attempt at recovery (executor failure / checkpoint recovery) also fails.How was this patch tested?
Unit test