Skip to content

Conversation

@holdenk
Copy link
Contributor

@holdenk holdenk commented Nov 12, 2016

What changes were proposed in this pull request?

Fix the flags used to specify the hadoop version

How was this patch tested?

Manually tested as part of #15659 by having the build succeed.

cc @JoshRosen

@SparkQA
Copy link

SparkQA commented Nov 12, 2016

Test build #68552 has finished for PR 15860 at commit f47101a.

  • This patch passes all tests.
  • This patch merges cleanly.
  • This patch adds no public classes.

@holdenk
Copy link
Contributor Author

holdenk commented Nov 12, 2016

re-ping @JoshRosen?

@JoshRosen
Copy link
Contributor

Looks good to me. I did a bit of digging and it looks like the bug that this fixes actually ended up causing silent failures in our nightly snapshot package builder:

In the builder, the invalid profiles showed up as warnings in the logs:

+ VERSION='[WARNING] The requested profile "hadoop2.6" could not be activated because it does not exist.'

While in the longer term it might be nice to strengthen error-checks in that script to make sure that this doesn't silently break, I don't think it's necessary to do now or a super high priority in general (since any bug here will be caught prior to release), so this looks good to me and I'll merge it now.

asfgit pushed a commit that referenced this pull request Nov 12, 2016
## What changes were proposed in this pull request?

Fix the flags used to specify the hadoop version

## How was this patch tested?

Manually tested as part of #15659 by having the build succeed.

cc joshrosen

Author: Holden Karau <holden@us.ibm.com>

Closes #15860 from holdenk/minor-fix-release-build-script.

(cherry picked from commit 1386fd2)
Signed-off-by: Josh Rosen <joshrosen@databricks.com>
@asfgit asfgit closed this in 1386fd2 Nov 12, 2016
uzadude pushed a commit to uzadude/spark that referenced this pull request Jan 27, 2017
## What changes were proposed in this pull request?

Fix the flags used to specify the hadoop version

## How was this patch tested?

Manually tested as part of apache#15659 by having the build succeed.

cc joshrosen

Author: Holden Karau <holden@us.ibm.com>

Closes apache#15860 from holdenk/minor-fix-release-build-script.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants