Skip to content

[SPARK-17116][Pyspark] Allow parameters to be {string,value} dict at runtime #15871

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
aditya1702 wants to merge 1 commit into from
Closed

[SPARK-17116][Pyspark] Allow parameters to be {string,value} dict at runtime #15871

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 6 additions & 0 deletions python/pyspark/ml/base.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -59,6 +59,12 @@ def fit(self, dataset, params=None):
return [self.fit(dataset, paramMap) for paramMap in params]
elif isinstance(params, dict):
if params:
if isinstance(params.keys()[0],str):
param_new = dict()
for param, value in params.items():
p = getattr(self, param)
param_new.update({p: value})
params=param_new
Copy link
Member

@HyukjinKwon HyukjinKwon Nov 14, 2016 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could we just make it just like the one as below?

params = dict([(getattr(self, p), v) for p, v in params.items()])

BTW, I am not supposed to decide what should be added into Spark. We can wait for committer's review :)

Copy link
Author

@aditya1702 aditya1702 Nov 15, 2016

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@HyukjinKwon Ok sure.

return self.copy(params)._fit(dataset)
else:
return self._fit(dataset)
Expand Down