[SPARK-18510][SQL] Follow up to address comments in #15951 #15997
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
zsxwing
commented
Nov 23, 2016
| } else { | ||
| // in streaming mode, we have already inferred and registered partition columns, we will | ||
| // never have to materialize the lazy val below | ||
| lazy val inferredPartitions = tempFileCatalog.partitionSchema |
Member
Author
There was a problem hiding this comment.
I removed this lazy val so that it's easy to track when tempFileCatalog is materialized.
zsxwing
commented
Nov 23, 2016
| // maintain old behavior before SPARK-18510. If userSpecifiedSchema is empty used inferred | ||
| // partitioning | ||
| if (userSpecifiedSchema.isEmpty) { | ||
| val inferredPartitions = tempFileIndex.partitionSchema |
Member
Author
There was a problem hiding this comment.
Still keep the inferredPartitions variable to document the meaning of tempFileIndex.partitionSchema.
Member
Author
Contributor
|
LGTM pending tests. |
|
Test build #69088 has finished for PR 15997 at commit
|
Contributor
|
Merging to master and 2.1 |
asfgit
pushed a commit
that referenced
this pull request
Nov 24, 2016
## What changes were proposed in this pull request? This PR addressed the rest comments in #15951. ## How was this patch tested? Jenkins Author: Shixiong Zhu <shixiong@databricks.com> Closes #15997 from zsxwing/SPARK-18510-follow-up. (cherry picked from commit 223fa21) Signed-off-by: Tathagata Das <tathagata.das1565@gmail.com>
robert3005
pushed a commit
to palantir/spark
that referenced
this pull request
Dec 2, 2016
## What changes were proposed in this pull request? This PR addressed the rest comments in apache#15951. ## How was this patch tested? Jenkins Author: Shixiong Zhu <shixiong@databricks.com> Closes apache#15997 from zsxwing/SPARK-18510-follow-up.
uzadude
pushed a commit
to uzadude/spark
that referenced
this pull request
Jan 27, 2017
## What changes were proposed in this pull request? This PR addressed the rest comments in apache#15951. ## How was this patch tested? Jenkins Author: Shixiong Zhu <shixiong@databricks.com> Closes apache#15997 from zsxwing/SPARK-18510-follow-up.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
This PR addressed the rest comments in #15951.
How was this patch tested?
Jenkins