Skip to content

[SPARK-18527][SQL] Convert decimal array to double array double for Hive UDAFPercentile #16034

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
hvanhovell wants to merge 1 commit into from
+13 −2
Closed

[SPARK-18527][SQL] Convert decimal array to double array double for Hive UDAFPercentile #16034

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 7 additions & 2 deletions sql/hive/src/main/scala/org/apache/spark/sql/hive/HiveSessionCatalog.scala
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -35,7 +35,7 @@ import org.apache.spark.sql.catalyst.plans.logical.{LogicalPlan, SubqueryAlias}
import org.apache.spark.sql.catalyst.rules.Rule
import org.apache.spark.sql.hive.HiveShim.HiveFunctionWrapper
import org.apache.spark.sql.internal.SQLConf
import org.apache.spark.sql.types.{DecimalType, DoubleType}
import org.apache.spark.sql.types.{ArrayType, DecimalType, DoubleType}
import org.apache.spark.util.Utils


Expand Down Expand Up @@ -166,8 +166,13 @@ private[sql] class HiveSessionCatalog(
} catch {
case NonFatal(_) =>
// SPARK-16228 ExternalCatalog may recognize `double`-type only.
// SPARK-18527 Percentile needs explicit cast to array<double>
val newChildren = children.map { child =>
if (child.dataType.isInstanceOf[DecimalType]) Cast(child, DoubleType) else child
child.dataType match {
case ArrayType(DecimalType(), nullable) => Cast(child, ArrayType(DoubleType, nullable))
case DecimalType() => Cast(child, DoubleType)
case _ => child
}
}
lookupFunction0(name, newChildren)
}
Expand Down
6 changes: 6 additions & 0 deletions sql/hive/src/test/scala/org/apache/spark/sql/hive/execution/HiveUDFSuite.scala
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -149,6 +149,12 @@ class HiveUDFSuite extends QueryTest with TestHiveSingleton with SQLTestUtils {
sql("select percentile_approx(value, 0.5) from values 1.0,2.0,3.0 T(value)")
}

test("SPARK-18527 Percentile needs explicit cast to array<double>") {
sql("select percentile(value, cast(array(0.1, 0.5) as array<double>))" +
"from values 1,2,3 T(value)")
sql("select percentile(value, array(0.1, 0.5)) from values 1,2,3 T(value)")
}

test("Generic UDAF aggregates") {

checkAnswer(sql(
Expand Down