Skip to content

Conversation

@zsxwing
Copy link
Member

@zsxwing zsxwing commented Dec 5, 2016

What changes were proposed in this pull request?

Move no data rate limit from StreamExecution to ProgressReporter to make recentProgresses and listener events consistent.

How was this patch tested?

Jenkins

@tdas
Copy link
Contributor

tdas commented Dec 5, 2016

LGTM.

@SparkQA
Copy link

SparkQA commented Dec 6, 2016

Test build #69686 has finished for PR 16155 at commit d4927e1.

  • This patch passes all tests.
  • This patch merges cleanly.
  • This patch adds no public classes.

@tdas
Copy link
Contributor

tdas commented Dec 6, 2016

Still LGTM. Merge when tests pass on the latest commit.

@SparkQA
Copy link

SparkQA commented Dec 6, 2016

Test build #69694 has finished for PR 16155 at commit 6e86b4e.

  • This patch passes all tests.
  • This patch merges cleanly.
  • This patch adds no public classes.

@SparkQA
Copy link

SparkQA commented Dec 6, 2016

Test build #69700 has finished for PR 16155 at commit acfd08f.

  • This patch passes all tests.
  • This patch merges cleanly.
  • This patch adds no public classes.

@tdas
Copy link
Contributor

tdas commented Dec 6, 2016

Merging to master and 2.1

asfgit pushed a commit that referenced this pull request Dec 6, 2016
…gressReporter

## What changes were proposed in this pull request?

Move no data rate limit from StreamExecution to ProgressReporter to make `recentProgresses` and listener events consistent.

## How was this patch tested?

Jenkins

Author: Shixiong Zhu <shixiong@databricks.com>

Closes #16155 from zsxwing/SPARK-18722.

(cherry picked from commit 4af142f)
Signed-off-by: Tathagata Das <tathagata.das1565@gmail.com>
@asfgit asfgit closed this in 4af142f Dec 6, 2016
@zsxwing zsxwing deleted the SPARK-18722 branch December 6, 2016 03:24
robert3005 pushed a commit to palantir/spark that referenced this pull request Dec 15, 2016
…gressReporter

## What changes were proposed in this pull request?

Move no data rate limit from StreamExecution to ProgressReporter to make `recentProgresses` and listener events consistent.

## How was this patch tested?

Jenkins

Author: Shixiong Zhu <shixiong@databricks.com>

Closes apache#16155 from zsxwing/SPARK-18722.
uzadude pushed a commit to uzadude/spark that referenced this pull request Jan 27, 2017
…gressReporter

## What changes were proposed in this pull request?

Move no data rate limit from StreamExecution to ProgressReporter to make `recentProgresses` and listener events consistent.

## How was this patch tested?

Jenkins

Author: Shixiong Zhu <shixiong@databricks.com>

Closes apache#16155 from zsxwing/SPARK-18722.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants