[SPARK-18846][Scheduler] Fix flakiness in SchedulerIntegrationSuite #16270
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There is a small race in SchedulerIntegrationSuite. The test assumes that the taskscheduler thread processing that last task will finish before the DAGScheduler processes the task event and notifies the job waiter, but that is not 100% guaranteed.
|
|
||
| import org.scalactic.TripleEquals | ||
| import org.scalatest.concurrent.Eventually._ | ||
| import org.scalatest.concurrent.PatienceConfiguration |
Contributor
There was a problem hiding this comment.
do you need this? (I compiled successfully w/o it)
| // and notifies the job waiter before our original thread in the task scheduler finishes | ||
| // handling the event and marks the taskset as complete. So its ok if we need to wait a | ||
| // *little* bit longer for the original taskscheduler thread to finish up to deal w/ the race. | ||
| eventually(timeout(1 second), interval(100 millis)) { |
Contributor
There was a problem hiding this comment.
I might do 10 millis here since it seems like there's not much cost here to checking more frequently, and 100 millis is somewhat long to wait
| import org.scalactic.TripleEquals | ||
| import org.scalatest.concurrent.Eventually._ | ||
| import org.scalatest.time.SpanSugar._ | ||
| import org.scalatest.Assertions.AssertionsHelper |
Contributor
There was a problem hiding this comment.
derp sorry just noticed this one is out of order (should be above org.scalatest.concurrent)
Contributor
Author
There was a problem hiding this comment.
no problem, sorry I never get these right -- I actually thought package imports were supposed to be first and checked some other places to realize you are right.
Contributor
|
LGTM |
|
Test build #70098 has finished for PR 16270 at commit
|
|
Test build #70099 has finished for PR 16270 at commit
|
|
Test build #70104 has finished for PR 16270 at commit
|
|
Test build #70108 has finished for PR 16270 at commit
|
Contributor
Author
|
merged to master |
robert3005
pushed a commit
to palantir/spark
that referenced
this pull request
Dec 15, 2016
There is a small race in SchedulerIntegrationSuite. The test assumes that the taskscheduler thread processing that last task will finish before the DAGScheduler processes the task event and notifies the job waiter, but that is not 100% guaranteed. ran the test locally a bunch of times, never failed, though admittedly it never failed locally for me before either. However I am nearly 100% certain this is what caused the failure of one jenkins build https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/68694/consoleFull (which is long gone now, sorry -- I fixed it as part of apache#14079 initially) Author: Imran Rashid <irashid@cloudera.com> Closes apache#16270 from squito/sched_integ_flakiness.
uzadude
pushed a commit
to uzadude/spark
that referenced
this pull request
Jan 27, 2017
There is a small race in SchedulerIntegrationSuite. The test assumes that the taskscheduler thread processing that last task will finish before the DAGScheduler processes the task event and notifies the job waiter, but that is not 100% guaranteed. ran the test locally a bunch of times, never failed, though admittedly it never failed locally for me before either. However I am nearly 100% certain this is what caused the failure of one jenkins build https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/68694/consoleFull (which is long gone now, sorry -- I fixed it as part of apache#14079 initially) Author: Imran Rashid <irashid@cloudera.com> Closes apache#16270 from squito/sched_integ_flakiness.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
There is a small race in SchedulerIntegrationSuite.
The test assumes that the taskscheduler thread
processing that last task will finish before the DAGScheduler processes
the task event and notifies the job waiter, but that is not 100%
guaranteed.
How was this patch tested?
ran the test locally a bunch of times, never failed, though admittedly it never failed locally for me either. However I am nearly 100% certain this is what caused the failure of one jenkins build https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/68694/consoleFull (which is long gone now, sorry -- I fixed it as part of #14079 initially)