[SPARK-18849][ML][SPARKR][DOC] vignettes final check update #16286
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Test build #70161 has finished for PR 16286 at commit
|
felixcheung
force-pushed
the
rvignettespass
branch
from
54665c9 to
6aea5f2
Compare
Member
Author
|
rebased on #16284 |
Member
Author
Contributor
|
LGTM. But I haven't been looking at the vignette PRs closely, so it might better if @mengxr took a loo k as well |
|
Test build #70165 has finished for PR 16286 at commit
|
Contributor
|
Merging this to master, branch-2.1 - to catch the next RC. @mengxr feel free to open a follow up if you find anything ? |
asfgit
pushed a commit
that referenced
this pull request
Dec 15, 2016
## What changes were proposed in this pull request? doc cleanup ## How was this patch tested? ~~vignettes is not building for me. I'm going to kick off a full clean build and try again and attach output here for review.~~ Output html here: https://felixcheung.github.io/sparkr-vignettes.html Author: Felix Cheung <felixcheung_m@hotmail.com> Closes #16286 from felixcheung/rvignettespass. (cherry picked from commit 7d858bc) Signed-off-by: Shivaram Venkataraman <shivaram@cs.berkeley.edu>
Contributor
|
I would vote for some logical grouping (instead of alphabetical ordering) and keep the sections in the same order, but it is not very necessary. |
robert3005
pushed a commit
to palantir/spark
that referenced
this pull request
Dec 15, 2016
## What changes were proposed in this pull request? doc cleanup ## How was this patch tested? ~~vignettes is not building for me. I'm going to kick off a full clean build and try again and attach output here for review.~~ Output html here: https://felixcheung.github.io/sparkr-vignettes.html Author: Felix Cheung <felixcheung_m@hotmail.com> Closes apache#16286 from felixcheung/rvignettespass.
uzadude
pushed a commit
to uzadude/spark
that referenced
this pull request
Jan 27, 2017
## What changes were proposed in this pull request? doc cleanup ## How was this patch tested? ~~vignettes is not building for me. I'm going to kick off a full clean build and try again and attach output here for review.~~ Output html here: https://felixcheung.github.io/sparkr-vignettes.html Author: Felix Cheung <felixcheung_m@hotmail.com> Closes apache#16286 from felixcheung/rvignettespass.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
doc cleanup
How was this patch tested?
vignettes is not building for me. I'm going to kick off a full clean build and try again and attach output here for review.Output html here: https://felixcheung.github.io/sparkr-vignettes.html