Skip to content

Conversation

@xuanyuanking
Copy link
Member

What changes were proposed in this pull request?

Backport of #16135 to branch-2.0

How was this patch tested?

Because of the diff between branch-2.0 and master/2.1, here add a multi-thread access table test in HiveMetadataCacheSuite and check it only loading once using metrics in HiveCatalogMetrics

@hvanhovell
Copy link
Contributor

Maybe we should just drop the UT (so we don't have to add the metrics). cc @ericl WDYT?

@SparkQA
Copy link

SparkQA commented Dec 20, 2016

Test build #70402 has finished for PR 16350 at commit 132d12e.

  • This patch fails Spark unit tests.
  • This patch merges cleanly.
  • This patch adds no public classes.

@SparkQA
Copy link

SparkQA commented Dec 20, 2016

Test build #70406 has finished for PR 16350 at commit 80b8664.

  • This patch passes all tests.
  • This patch merges cleanly.
  • This patch adds no public classes.

@ericl
Copy link
Contributor

ericl commented Dec 21, 2016

yeah, i don't think we need the unit test for 2.0

@xuanyuanking
Copy link
Member Author

Delete the UT and metrics done. :)

@SparkQA
Copy link

SparkQA commented Dec 21, 2016

Test build #70452 has finished for PR 16350 at commit 8dd0169.

  • This patch passes all tests.
  • This patch merges cleanly.
  • This patch adds no public classes.

@hvanhovell
Copy link
Contributor

LGTM - merging to branch-2.0. Thanks!

Can you close this one? Our tooling only closes PRs against master.

asfgit pushed a commit that referenced this pull request Dec 21, 2016
…ation in cache

## What changes were proposed in this pull request?

Backport of #16135 to branch-2.0

## How was this patch tested?

Because of the diff between branch-2.0 and master/2.1, here add a multi-thread access table test in `HiveMetadataCacheSuite` and check it only loading once using metrics in `HiveCatalogMetrics`

Author: xuanyuanking <xyliyuanjian@gmail.com>

Closes #16350 from xuanyuanking/SPARK-18700-2.0.
@xuanyuanking
Copy link
Member Author

Thanks!

@xuanyuanking xuanyuanking deleted the SPARK-18700-2.0 branch January 5, 2017 10:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants